From patchwork Wed Jul 24 13:22:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 33789 Received: (qmail 30210 invoked by alias); 24 Jul 2019 13:22:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 30202 invoked by uid 89); 24 Jul 2019 13:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:mvmlfwn, H*f:sk:mvmlfwn X-HELO: mail-qt1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Az9Iv4FbkLstQFjnuDxx8ZgJK6L29HzD4O1PkZk987g=; b=ZhCPl6MAtSNmPsC3O3CKsvH8mPwsj+kbDloQ58ZLd6AVapa05hRiTRXPuH4X4rv42Y zgOko/npOxJTditPW8cPVNWYw9oWuD/XzrnKz4TFwqgwGCTwTfmW7ZNJzrlBexSLjodo SNL5Kk6hbtaoTag66MjcwSej2Ie/Xz2VVIIRbxFPSQED4zqZXMLZU+Z2CPJ0sMi4now6 FmeQM0WnXyP2ph7GiPJDQOdMTRgoQFZ6z+A9GZedy9BZ9QqNX0aBl8e8fbKayUTYyzx8 ZOHSGsdViW0HeF7QlZqvftYmePMqo/37z3oq510V+C6L2aydlmTZVStNpMevGsTTjdE+ jyAg== Return-Path: Subject: Re: [PATCH 4/4] sysvipc: Set ipc_perm mode as mode_t (BZ#18231) To: Andreas Schwab Cc: libc-alpha@sourceware.org References: <20190724124959.15620-1-adhemerval.zanella@linaro.org> <20190724124959.15620-4-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: Date: Wed, 24 Jul 2019 10:22:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: On 24/07/2019 10:00, Andreas Schwab wrote: > On Jul 24 2019, Adhemerval Zanella wrote: > >> 3. All kernel ABIs for the supported architectures already provides the >> expected padding for mode type extension to 32-bit. However, some >> architectures the padding has the wrong placement, so it requires >> the ipc control routines (msgctl, semctl, and shmctl) to adjust the >> mode field accordingly. Currently they are armeb, microblaze, s390, >> and sheb. > > and m68k. > > Andreas. > Indeed, I added the following changes on the patch (along with required CL entries): diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist index 05633b3cb8..a2be040dfc 100644 --- a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist +++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist @@ -129,6 +129,9 @@ GLIBC_2.29 posix_spawn_file_actions_addchdir_np F GLIBC_2.29 posix_spawn_file_actions_addfchdir_np F GLIBC_2.30 getdents64 F GLIBC_2.30 gettid F +GLIBC_2.30 msgctl F +GLIBC_2.30 semctl F +GLIBC_2.30 shmctl F GLIBC_2.30 tgkill F GLIBC_2.30 twalk_r F GLIBC_2.4 _Exit F diff --git a/sysdeps/unix/sysv/linux/m68k/kernel-features.h b/sysdeps/unix/sysv/linux/m68k/kernel-features.h index c9be6bc167..dbf1bad597 100644 --- a/sysdeps/unix/sysv/linux/m68k/kernel-features.h +++ b/sysdeps/unix/sysv/linux/m68k/kernel-features.h @@ -55,3 +55,4 @@ # undef __ASSUME_DIRECT_SYSVIPC_SYSCALLS # undef __ASSUME_SYSVIPC_DEFAULT_IPC_64 #endif +#undef __ASSUME_SYSVIPC_SUPPORT_MODE32 diff --git a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist index 47eb7b4608..6f8f77de1d 100644 --- a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist +++ b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist @@ -2148,6 +2148,9 @@ GLIBC_2.3.4 xdr_quad_t F GLIBC_2.3.4 xdr_u_quad_t F GLIBC_2.30 getdents64 F GLIBC_2.30 gettid F +GLIBC_2.30 msgctl F +GLIBC_2.30 semctl F +GLIBC_2.30 shmctl F GLIBC_2.30 tgkill F GLIBC_2.30 twalk_r F GLIBC_2.4 __confstr_chk F