Patchwork [4/4] sysvipc: Set ipc_perm mode as mode_t (BZ#18231)

login
register
mail settings
Submitter Adhemerval Zanella Netto
Date July 24, 2019, 1:22 p.m.
Message ID <acf5444d-97b3-6d6e-7dfb-96a0f2ea3e79@linaro.org>
Download mbox | patch
Permalink /patch/33789/
State New
Headers show

Comments

Adhemerval Zanella Netto - July 24, 2019, 1:22 p.m.
On 24/07/2019 10:00, Andreas Schwab wrote:
> On Jul 24 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>>   3. All kernel ABIs for the supported architectures already provides the
>>      expected padding for mode type extension to 32-bit.  However, some
>>      architectures the padding has the wrong placement, so it requires
>>      the ipc control routines (msgctl, semctl, and shmctl) to adjust the
>>      mode field accordingly.  Currently they are armeb, microblaze, s390,
>>      and sheb.
> 
> and m68k.
> 
> Andreas.
> 

Indeed, I added the following changes on the patch (along with required
CL entries):

Patch

diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist
index 05633b3cb8..a2be040dfc 100644
--- a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist
+++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist
@@ -129,6 +129,9 @@  GLIBC_2.29 posix_spawn_file_actions_addchdir_np F
 GLIBC_2.29 posix_spawn_file_actions_addfchdir_np F
 GLIBC_2.30 getdents64 F
 GLIBC_2.30 gettid F
+GLIBC_2.30 msgctl F
+GLIBC_2.30 semctl F
+GLIBC_2.30 shmctl F
 GLIBC_2.30 tgkill F
 GLIBC_2.30 twalk_r F
 GLIBC_2.4 _Exit F
diff --git a/sysdeps/unix/sysv/linux/m68k/kernel-features.h b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
index c9be6bc167..dbf1bad597 100644
--- a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
+++ b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
@@ -55,3 +55,4 @@ 
 # undef __ASSUME_DIRECT_SYSVIPC_SYSCALLS
 # undef __ASSUME_SYSVIPC_DEFAULT_IPC_64
 #endif
+#undef __ASSUME_SYSVIPC_SUPPORT_MODE32
diff --git a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist
index 47eb7b4608..6f8f77de1d 100644
--- a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist
+++ b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist
@@ -2148,6 +2148,9 @@  GLIBC_2.3.4 xdr_quad_t F
 GLIBC_2.3.4 xdr_u_quad_t F
 GLIBC_2.30 getdents64 F
 GLIBC_2.30 gettid F
+GLIBC_2.30 msgctl F
+GLIBC_2.30 semctl F
+GLIBC_2.30 shmctl F
 GLIBC_2.30 tgkill F
 GLIBC_2.30 twalk_r F
 GLIBC_2.4 __confstr_chk F