[v2] Added International_Standard_Book_Number (ISBN) for various Locales
Commit Message
We foud missing ISBN code for various locale. Currently we added ISBN code for
"Ethiopia” and "Eritrea". Later we will update ISBN code for others too.
Link:
[1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
[BZ #24817]
* locales/aa_ER (country_isbn): Added country_isbn.
* locales/aa_ET (country_isbn): Likewise.
* locales/am_ET (country_isbn): Likewise.
* locales/byn_ER (country_isbn): Likewise.
* locales/gez_ER (country_isbn): Likewise.
* locales/gez_ET (country_isbn): Likewise.
* locales/om_ET (country_isbn): Likewise.
* locales/sid_ET (country_isbn): Likewise.
* locales/so_ET (country_isbn): Likewise.
* locales/ti_ER (country_isbn): Likewise.
* locales/ti_ET (country_isbn): Likewise.
* locales/tig_ER (country_isbn): Likewise.
* locales/wal_ET (country_isbn): Likewise.
---
localedata/locales/aa_ER | 3 ++-
localedata/locales/aa_ET | 3 ++-
localedata/locales/am_ET | 3 ++-
localedata/locales/byn_ER | 3 ++-
localedata/locales/gez_ER | 3 ++-
localedata/locales/gez_ET | 3 ++-
localedata/locales/om_ET | 3 ++-
localedata/locales/sid_ET | 3 ++-
localedata/locales/so_ET | 3 ++-
localedata/locales/ti_ER | 3 ++-
localedata/locales/ti_ET | 3 ++-
localedata/locales/tig_ER | 3 ++-
localedata/locales/wal_ET | 3 ++-
13 files changed, 26 insertions(+), 13 deletions(-)
Comments
22.07.2019 06:59 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
> We foud missing ISBN code for various locale. Currently we added ISBN code
> for
> "Ethiopia” and "Eritrea". Later we will update ISBN code for others too.
>
> Link:
> [1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
>
> [BZ #24817]
> * locales/aa_ER (country_isbn): Added country_isbn.
> * locales/aa_ET (country_isbn): Likewise.
> * locales/am_ET (country_isbn): Likewise.
> * locales/byn_ER (country_isbn): Likewise.
> * locales/gez_ER (country_isbn): Likewise.
> * locales/gez_ET (country_isbn): Likewise.
> * locales/om_ET (country_isbn): Likewise.
> * locales/sid_ET (country_isbn): Likewise.
> * locales/so_ET (country_isbn): Likewise.
> * locales/ti_ER (country_isbn): Likewise.
> * locales/ti_ET (country_isbn): Likewise.
> * locales/tig_ER (country_isbn): Likewise.
> * locales/wal_ET (country_isbn): Likewise.
> ---
> localedata/locales/aa_ER | 3 ++-
> localedata/locales/aa_ET | 3 ++-
> localedata/locales/am_ET | 3 ++-
> localedata/locales/byn_ER | 3 ++-
> localedata/locales/gez_ER | 3 ++-
> localedata/locales/gez_ET | 3 ++-
> localedata/locales/om_ET | 3 ++-
> localedata/locales/sid_ET | 3 ++-
> localedata/locales/so_ET | 3 ++-
> localedata/locales/ti_ER | 3 ++-
> localedata/locales/ti_ET | 3 ++-
> localedata/locales/tig_ER | 3 ++-
> localedata/locales/wal_ET | 3 ++-
> 13 files changed, 26 insertions(+), 13 deletions(-)
> [...]
Thank you for this contribution, Akhilesh. There are several new
issues in your patch. But before I discuss them the major question is:
Carlos, do we want to fix this issue now as we are in the freeze period,
10 days before the next release?
Regards,
Rafal
On 7/22/19 3:39 PM, Rafal Luzynski wrote:
> 22.07.2019 06:59 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>
>> We foud missing ISBN code for various locale. Currently we added ISBN code
>> for
>> "Ethiopia” and "Eritrea". Later we will update ISBN code for others too.
>>
>> Link:
>> [1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
>>
>> [BZ #24817]
>> * locales/aa_ER (country_isbn): Added country_isbn.
>> * locales/aa_ET (country_isbn): Likewise.
>> * locales/am_ET (country_isbn): Likewise.
>> * locales/byn_ER (country_isbn): Likewise.
>> * locales/gez_ER (country_isbn): Likewise.
>> * locales/gez_ET (country_isbn): Likewise.
>> * locales/om_ET (country_isbn): Likewise.
>> * locales/sid_ET (country_isbn): Likewise.
>> * locales/so_ET (country_isbn): Likewise.
>> * locales/ti_ER (country_isbn): Likewise.
>> * locales/ti_ET (country_isbn): Likewise.
>> * locales/tig_ER (country_isbn): Likewise.
>> * locales/wal_ET (country_isbn): Likewise.
>> ---
>> localedata/locales/aa_ER | 3 ++-
>> localedata/locales/aa_ET | 3 ++-
>> localedata/locales/am_ET | 3 ++-
>> localedata/locales/byn_ER | 3 ++-
>> localedata/locales/gez_ER | 3 ++-
>> localedata/locales/gez_ET | 3 ++-
>> localedata/locales/om_ET | 3 ++-
>> localedata/locales/sid_ET | 3 ++-
>> localedata/locales/so_ET | 3 ++-
>> localedata/locales/ti_ER | 3 ++-
>> localedata/locales/ti_ET | 3 ++-
>> localedata/locales/tig_ER | 3 ++-
>> localedata/locales/wal_ET | 3 ++-
>> 13 files changed, 26 insertions(+), 13 deletions(-)
>> [...]
>
> Thank you for this contribution, Akhilesh. There are several new
> issues in your patch. But before I discuss them the major question is:
>
> Carlos, do we want to fix this issue now as we are in the freeze period,
> 10 days before the next release?
These are new features. I'd like these to wait.
@@ -112,7 +112,8 @@ country_ab2 "ER"
country_ab3 "ERI"
country_num 232
country_car "ER"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99948
lang_name "Qafar"
lang_ab "aa"
lang_term "aar"
@@ -112,7 +112,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "Qafar"
lang_ab "aa"
lang_term "aar"
@@ -947,7 +947,8 @@ country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
% ETH
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "<U12A0><U121B><U122D><U129B>"
lang_ab "am"
lang_term "amh"
@@ -123,7 +123,8 @@ country_ab2 "ER"
country_ab3 "ERI"
country_num 232
country_car "ER"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99948
lang_name "<U1265><U120A><U1295>"
lang_ab ""
lang_term "byn"
@@ -110,7 +110,8 @@ country_ab2 "ER"
country_ab3 "ERI"
country_num 232
country_car "ER"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99948
lang_name "<U130D><U12D5><U12DD>"
lang_term "gez"
%
@@ -110,7 +110,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "<U130D><U12D5><U12DD>"
lang_term "gez"
%
@@ -145,7 +145,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "Oromoo"
lang_ab "om"
lang_term "orm"
@@ -113,7 +113,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "Sidaamu Afo"
lang_term "sid"
lang_lib "sid"
@@ -123,7 +123,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "Soomaali"
lang_ab "so"
lang_term "som"
@@ -143,7 +143,8 @@ country_ab2 "ER"
country_ab3 "ERI"
country_num 232
country_car "ER"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99948
lang_name "<U1275><U130D><U122D><U129B>"
lang_ab "ti"
lang_term "tir"
@@ -946,7 +946,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "<U1275><U130D><U122D><U129B>"
lang_ab "ti"
lang_term "tir"
@@ -123,7 +123,8 @@ country_ab2 "ER"
country_ab3 "ERI"
country_num 232
country_car "ER"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99948
lang_name "<U1275><U130D><U1228>"
lang_ab ""
lang_term "tig"
@@ -110,7 +110,8 @@ country_ab2 "ET"
country_ab3 "ETH"
country_num 231 % 210 found in at least one ISO 3166 doc
country_car "ETH"
-% country_isbn unknown, Need ISO 2108
+#https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
+country_isbn 99944
lang_name "<U12C8><U120B><U12ED><U1273><U1271>"
lang_term "wal"
lang_lib "wal"