From patchwork Tue Jul  9 01:30:36 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: =?utf-8?b?5q+b5pmX?= <han_mao@c-sky.com>
X-Patchwork-Id: 33625
Received: (qmail 103746 invoked by alias); 9 Jul 2019 01:32:10 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 103738 invoked by uid 89); 9 Jul 2019 01:32:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-21.1 required=5.0 tests=AWL, BAYES_00,
	GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
	UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy=
X-HELO: smtp2200-217.mail.aliyun.com
X-Alimail-AntiSpam: AC=CONTINUE; BC=0.1022291|-1; CH=green;
	DM=CONTINUE|CONTINUE|true|0.113504-0.0139808-0.872515;
	FP=0|0|0|0|0|-1|-1|-1; HT=e02c03309; MF=han_mao@c-sky.com;
	NM=1; PH=DS; RN=2; RT=2; SR=0; TI=SMTPD_---.Ev0KK-5_1562635925;
Date: Tue, 9 Jul 2019 09:30:36 +0800
From: Mao Han <han_mao@c-sky.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [RFC 1/1] testcase fail while using cross-test-ssh wrapper
Message-ID: <20190709013036.GA7671@vmh-VirtualBox>
References: 
 <6067f3ff4ac4b7e991405f216e928e62f4780c8b.1561620739.git.han_mao@c-sky.com>
	<87d0iku3rq.fsf@oldenburg2.str.redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <87d0iku3rq.fsf@oldenburg2.str.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Mon, Jul 08, 2019 at 02:09:13PM +0200, Florian Weimer wrote:
> * Mao Han:
> >  
> >  common_objpfx=$1
> > -test_wrapper_env=$2
> > -run_program_env=$3
> > +test_wrapper_env=$3
> > +run_program_env=
> >  
> >  LIBPATH="$common_objpfx"
> 
> Sorry, this patch doesn't look correct to me.  Why is it appropriate to
> ignore evironment variables passed to the test script?

I was not intend to ignore the evironment variables. I just posted the problem
I've got and how did I avoid that.
The argument passed by Makefile is:
$(objpfx)tst-locale-locpath.out : tst-locale-locpath.sh $(objpfx)locale
        $(SHELL) $< '$(common-objpfx)' '$(test-wrapper)' '$(test-wrapper-env)'
But the argument taken by the script is:
common_objpfx=$1
test_wrapper_env=$2
run_program_env=$3
The test-wrapper is passed twice and no run_program_env is passed. I don't know
whether the test-wrapper script is unnecessary(last patch) or the argument passed
by Makefile is wrong:


Thanks,
Mao Han

diff --git a/locale/Makefile b/locale/Makefile
index 0ad99ec..d78cf9b 100644
--- a/locale/Makefile
+++ b/locale/Makefile
@@ -113,5 +113,5 @@ lib := locale-programs
 include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
 
 $(objpfx)tst-locale-locpath.out : tst-locale-locpath.sh $(objpfx)locale
-       $(SHELL) $< '$(common-objpfx)' '$(test-wrapper)' '$(test-wrapper-env)' > $@; \
+       $(SHELL) $< '$(common-objpfx)' '$(test-wrapper-env)' '$(run-program-env)' > $@; \
        $(evaluate-test)