Patchwork NEWS: clarify copy_file_range

login
register
mail settings
Submitter DJ Delorie
Date July 2, 2019, 7:17 p.m.
Message ID <xnwoh0s0t4.fsf@greed.delorie.com>
Download mbox | patch
Permalink /patch/33518/
State New
Headers show

Comments

DJ Delorie - July 2, 2019, 7:17 p.m.
Florian asked me for feedback wrt this discussion:
  https://lists.gnu.org/archive/html/bug-gnulib/2019-06/msg00109.html

I propose a slight re-wording of NEWS to clarify what applications
must do wrt the copy_file_range change:
Florian Weimer - July 2, 2019, 7:19 p.m.
* DJ Delorie:

> Florian asked me for feedback wrt this discussion:
>   https://lists.gnu.org/archive/html/bug-gnulib/2019-06/msg00109.html
>
> I propose a slight re-wording of NEWS to clarify what applications
> must do wrt the copy_file_range change:
>
> diff --git a/NEWS b/NEWS
> index 6c7de105ac..11099f7248 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -46,9 +46,11 @@ Deprecated and removed features, and other changes affecting compatibility:
>    support the system call of the same name.  Previously, user space
>    emulation was performed, but its behavior did not match the kernel
>    behavior, which was deemed too confusing.  Applications which use the
> -  copy_file_range function will have to be run on kernels which implement
> -  the copy_file_range system call.  Support for most architectures was added
> -  in version 4.5 of the mainline Linux kernel.
> +  copy_file_range function can no longer rely on glibc to provide a fallback
> +  on kernels that do not support the copy_file_range system call, and if
> +  this function returns ENOSYS, they will need to use their own fallback.
> +  Support for copy_file_range for most architectures was added in version
> +  4.5 of the mainline Linux kernel.

Looks good to me.  Thanks.

Patch

diff --git a/NEWS b/NEWS
index 6c7de105ac..11099f7248 100644
--- a/NEWS
+++ b/NEWS
@@ -46,9 +46,11 @@  Deprecated and removed features, and other changes affecting compatibility:
   support the system call of the same name.  Previously, user space
   emulation was performed, but its behavior did not match the kernel
   behavior, which was deemed too confusing.  Applications which use the
-  copy_file_range function will have to be run on kernels which implement
-  the copy_file_range system call.  Support for most architectures was added
-  in version 4.5 of the mainline Linux kernel.
+  copy_file_range function can no longer rely on glibc to provide a fallback
+  on kernels that do not support the copy_file_range system call, and if
+  this function returns ENOSYS, they will need to use their own fallback.
+  Support for copy_file_range for most architectures was added in version
+  4.5 of the mainline Linux kernel.
 
 * The functions clock_gettime, clock_getres, clock_settime,
   clock_getcpuclockid, clock_nanosleep were removed from the librt library