Patchwork malloc programs independently depend on libpthread

login
register
mail settings
Submitter Florian Weimer
Date July 2, 2019, 2:43 p.m.
Message ID <87ef381oqk.fsf@oldenburg2.str.redhat.com>
Download mbox | patch
Permalink /patch/33512/
State Committed
Headers show

Comments

Florian Weimer - July 2, 2019, 2:43 p.m.
* Andreas Schwab:

> On Jul 02 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> What's the best way to solve this?  Move memusagestat to a different
>> subdirectory which comes after nptl?
>
> Can we make malloc depend on nptl?

Ah, I had not considered that mechanism because I had forgotten about
it.

What about this?  It appears to fix the build order.  Since it works on
Linux without htl, I expect it will work on Hurd with nptl, too.  And
nscd/Depend does the same thing today.

2019-07-02  Florian Weimer  <fweimer@redhat.com>

	[BZ #24757]
	* malloc/Depend: Add nptl and htl, due to potential indirect
	libpthread dependency of memusagestat.


Thanks,
Florian
Andreas Schwab - July 2, 2019, 2:47 p.m.
On Jul 02 2019, Florian Weimer <fweimer@redhat.com> wrote:

> 	[BZ #24757]
> 	* malloc/Depend: Add nptl and htl, due to potential indirect
> 	libpthread dependency of memusagestat.

Ok.

Andreas.
Florian Weimer - July 2, 2019, 2:52 p.m.
* Andreas Schwab:

> On Jul 02 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> 	[BZ #24757]
>> 	* malloc/Depend: Add nptl and htl, due to potential indirect
>> 	libpthread dependency of memusagestat.
>
> Ok.

Nice, this was quick and unexpectedly easy. 8-)

Thanks,
Florian

Patch

diff --git a/malloc/Depend b/malloc/Depend
index 910c6d9152..f5e248047c 100644
--- a/malloc/Depend
+++ b/malloc/Depend
@@ -1 +1,3 @@ 
 dlfcn
+nptl
+htl