From patchwork Tue Jun 25 13:15:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 33393 Received: (qmail 47806 invoked by alias); 25 Jun 2019 13:16:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 47687 invoked by uid 89); 25 Jun 2019 13:15:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com From: Stefan Liebler Subject: [PATCH] Fix build warnings in nptl/tst-eintr1.c To: GNU C Library Date: Tue, 25 Jun 2019 15:15:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 x-cbid: 19062513-0016-0000-0000-0000028C372B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19062513-0017-0000-0000-000032E9A9D3 Message-Id: <3f551a0b-1c2b-d215-878a-4259789fc58e@linux.ibm.com> Hi, this patch fixes the gcc warnings seen with gcc 9.1 -O3 on s390x: tst-eintr1.c: In function ‘tf1’: tst-eintr1.c:46:1: error: no return statement in function returning non-void [-Werror=return-type] 46 | } | ^ tst-eintr1.c: In function ‘do_test’: tst-eintr1.c:57:17: error: unused variable ‘th’ [-Werror=unused-variable] 57 | pthread_t th = xpthread_create (NULL, tf1, NULL); | ^~ Bye Stefan ChangeLog: * nptl/tst-eintr1.c (tf1): Add return statement. (do_test): Remove unused th variable. commit 2d77bc90e2d16f88eb242c3daf2778b009a9234e Author: Stefan Liebler Date: Mon Jun 24 12:11:48 2019 +0200 Fix build warnings in nptl/tst-eintr1.c This patch fixes the gcc warnings seen with gcc 9.1 -O3 on s390x: tst-eintr1.c: In function ‘tf1’: tst-eintr1.c:46:1: error: no return statement in function returning non-void [-Werror=return-type] 46 | } | ^ tst-eintr1.c: In function ‘do_test’: tst-eintr1.c:57:17: error: unused variable ‘th’ [-Werror=unused-variable] 57 | pthread_t th = xpthread_create (NULL, tf1, NULL); | ^~ ChangeLog: * nptl/tst-eintr1.c (tf1): Add return statement. (do_test): Remove unused th variable. diff --git a/nptl/tst-eintr1.c b/nptl/tst-eintr1.c index b60b796d61..256f5e94f8 100644 --- a/nptl/tst-eintr1.c +++ b/nptl/tst-eintr1.c @@ -43,6 +43,7 @@ tf1 (void *arg) pthread_t th = xpthread_create (NULL, tf2, NULL); xpthread_join (th); } + return NULL; } @@ -54,7 +55,7 @@ do_test (void) int i; for (i = 0; i < 10; ++i) { - pthread_t th = xpthread_create (NULL, tf1, NULL); + xpthread_create (NULL, tf1, NULL); } delayed_exit (3);