From patchwork Wed Jun 5 09:38:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 33014 Received: (qmail 93179 invoked by alias); 5 Jun 2019 09:38:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 93171 invoked by uid 89); 5 Jun 2019 09:38:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jun 2019 09:38:24 +0000 Received: by mail-wr1-f65.google.com with SMTP id e16so10481663wrn.1 for ; Wed, 05 Jun 2019 02:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zwSWdWysaaa54EbQdWY9KAYu6T69CudqeKWJn+AWBj0=; b=Q7rDP6LYYOcxT919NLkc8b3wyjUKKTyF/JW98mFYKtq4h6p6SIdnagGXJHJhXvsxyU 5n9h8Tuluzw1SEY2M2Ay604ItLiYFjM/CcnyrWM39hHsPR4mIIw6+xIeddHI8n2Se4Gu bAHxM4SH5hEDdFtbqorYGy6JnVCJPGMdz6KT1jFabSglFANBfAmTr6G69KNOPRs/LPhv O0Qt8xy6YBhSyfa3Cr8FSiuPJOrmMocZ6d1j0qyjv0kSi0Rq0QOTLp76m65J+o7qwbTj Su0+FfUlvo9LhiTSta+G5KiYW9CuZn1jJRIfPRr0v2GJH/4dhc2354oTtKk9uDuGueba DNHg== Return-Path: Received: from localhost (host86-180-62-212.range86-180.btcentralplus.com. [86.180.62.212]) by smtp.gmail.com with ESMTPSA id g11sm17809377wrq.89.2019.06.05.02.38.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 02:38:21 -0700 (PDT) Date: Wed, 5 Jun 2019 10:38:21 +0100 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org, Jim Wilson , Palmer Dabbelt Subject: Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction Message-ID: <20190605093820.GE23204@embecosm.com> References: <20190604115054.25306-1-andrew.burgess@embecosm.com> <998212a3-4a1d-12ad-2a16-aa05a0e4101c@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <998212a3-4a1d-12ad-2a16-aa05a0e4101c@redhat.com> X-Fortune: Money is the root of all wealth. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes * Pedro Alves [2019-06-05 10:12:12 +0100]: > On 6/4/19 12:50 PM, Andrew Burgess wrote: > > + prologue scanner will try to decode it. These long > > + instructions are ISA extensions, I use .byte rather than an > > + actual instruction mnemonic so that the test can be compiled > > Tiny nit, but please avoid "I" in comments. Either just don't use a > pronoun, e.g.: > > Since these long instructions are ISA extensions, use .byte > > or use "we" instead. I pushed the patch below. Thanks, Andrew --- commit 0088ba596bba2e0b94139f1c2c4f5875848edbd6 Author: Andrew Burgess Date: Wed Jun 5 10:33:54 2019 +0100 gdb/testsuite: Improve comments in recently added test Remove the use of 'I' within some comments in a recently added test. gdb/testsuite/ChangeLog: * gdb.arch/riscv-unwind-long-insn-6.s: Remove use of 'I' in comment. * gdb.arch/riscv-unwind-long-insn-8.s: Likewise. diff --git a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s index b21b1e10f32..9bbc0ca429b 100644 --- a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s +++ b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-6.s @@ -29,7 +29,7 @@ bar: func: /* A fake 6 byte instruction. This is never executed, but the prologue scanner will try to decode it. These long - instructions are ISA extensions, I use .byte rather than an + instructions are ISA extensions, use .byte rather than an actual instruction mnemonic so that the test can be compiled with a toolchain that doesn't include any long instruction extensions. */ diff --git a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s index 3fad07b59dd..0bf86940a7b 100644 --- a/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s +++ b/gdb/testsuite/gdb.arch/riscv-unwind-long-insn-8.s @@ -29,7 +29,7 @@ bar: func: /* A fake 8 byte instruction. This is never executed, but the prologue scanner will try to decode it. These long - instructions are ISA extensions, I use .byte rather than an + instructions are ISA extensions, use .byte rather than an actual instruction mnemonic so that the test can be compiled with a toolchain that doesn't include any long instruction extensions. */