From patchwork Tue May 28 16:58:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 32873 Received: (qmail 60290 invoked by alias); 28 May 2019 16:58:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 60282 invoked by uid 89); 28 May 2019 16:58:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=uppercase, HX-Languages-Length:1640, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 May 2019 16:58:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 226E5116320; Tue, 28 May 2019 12:58:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dmhbQP-TEWjU; Tue, 28 May 2019 12:58:41 -0400 (EDT) Received: from murgatroyd.Home (174-29-48-168.hlrn.qwest.net [174.29.48.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id B160E116312; Tue, 28 May 2019 12:58:40 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Joel Brobecker , Tom Tromey Subject: [PATCH] Fix failure in gdb.ada/complete.exp Date: Tue, 28 May 2019 10:58:38 -0600 Message-Id: <20190528165838.17156-1-tromey@adacore.com> MIME-Version: 1.0 I noticed a failure in gdb.ada/complete.exp when testing locally: FAIL: gdb.ada/complete.exp: complete break ada This failed due to this output: [...] break ada/generated/gnatvsn.ads break ada/libgnat/s-excmac.ads break ada/sdefault.adb break ada/snames.adb break ada/snames.ads This patch updates the regexp to allow "/" and "-" to appear. gdb/testsuite/ChangeLog 2019-05-28 Tom Tromey * gdb.ada/complete.exp (test_gdb_no_completion): Add "/" and "-" to "break complete ada" test case's regexp. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.ada/complete.exp | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.ada/complete.exp b/gdb/testsuite/gdb.ada/complete.exp index 8a5ef89dddb..1746c18463d 100644 --- a/gdb/testsuite/gdb.ada/complete.exp +++ b/gdb/testsuite/gdb.ada/complete.exp @@ -212,13 +212,14 @@ test_gdb_complete "ambiguous_func" \ # However, we want to sanity-check each one of them, knowing that # each result should start with "break ada" and that the proposed # completion should look like a valid symbol name (in particular, -# no uppercase letters...). See gdb/22670. +# no uppercase letters...). See gdb/22670. File names are OK as +# well, which is why "/" and "-" appear in the regexp. gdb_test_no_output "set max-completions unlimited" set test "complete break ada" gdb_test_multiple "$test" $test { - -re "^$test$eol\(break ada(\[a-z0-9._@\])*$eol\)+$gdb_prompt $" { + -re "^$test$eol\(break ada\[-a-z0-9._@/\]*$eol\)+$gdb_prompt $" { pass $test } -re "\[A-Z\].*$gdb_prompt $" {