From patchwork Tue May 14 15:12:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 32685 Received: (qmail 61416 invoked by alias); 14 May 2019 15:13:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 61348 invoked by uid 89); 14 May 2019 15:13:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=exercises, triplets X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40078.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 May 2019 15:13:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jEhimbtjsBudrfAo1UyxcRwLOY2w08qMpKb++Oi96Yk=; b=VXkvu/oJxJ9shd3uRsBx5NDZmP7USlrUdJU51+5Kg9wxzy7yilZhP4+CMSTAcVqp2JcdmQcYcGjtoRkwvVJkjR29+1aaQQb2F+nki2TG9XWR91nnkHNi7SOL+WiBbv5f9RUGZqfDX5a8yOswVZPncoJCVvT3tcjIFvxpaad6vJE= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2535.eurprd08.prod.outlook.com (10.172.251.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.24; Tue, 14 May 2019 15:12:49 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1878.024; Tue, 14 May 2019 15:12:49 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd , Alan Hayward Subject: [PATCH 9/9] testsuite: Remove TRANSCRIPT support Date: Tue, 14 May 2019 15:12:49 +0000 Message-ID: <20190514151238.8765-10-alan.hayward@arm.com> References: <20190514151238.8765-1-alan.hayward@arm.com> In-Reply-To: <20190514151238.8765-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:9508; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes TRANSCRIPT is superseeded by the .in, .cmd and .debug files, and can be removed. 2019-05-14 Alan Hayward * README (Running the Testsuite): Change example. (Testsuite Parameters): Remove TRANSCRIPT. * lib/gdb.exp: Remove TRANSCRIPT check. --- gdb/testsuite/README | 23 ++----------------- gdb/testsuite/lib/gdb.exp | 47 --------------------------------------- 2 files changed, 2 insertions(+), 68 deletions(-) -- 2.20.1 (Apple Git-117) diff --git a/gdb/testsuite/README b/gdb/testsuite/README index b5fbb456bee..a2baaee38eb 100644 --- a/gdb/testsuite/README +++ b/gdb/testsuite/README @@ -13,14 +13,14 @@ There are two ways to run the testsuite and pass additional parameters to DejaGnu. The first is to do `make check' in the main build directory and specifying the makefile variable `RUNTESTFLAGS': - make check RUNTESTFLAGS='TRANSCRIPT=y gdb.base/a2-run.exp' + make check RUNTESTFLAGS='GDB=/usr/bin/gdb gdb.base/a2-run.exp' The second is to cd to the testsuite directory and invoke the DejaGnu `runtest' command directly. cd testsuite make site.exp - runtest TRANSCRIPT=y + runtest GDB=/usr/bin/gdb (The `site.exp' file contains a handful of useful variables like host and target triplets, and pathnames.) @@ -147,25 +147,6 @@ Testsuite Parameters The following parameters are DejaGNU variables that you can set to affect the testsuite run globally. -TRANSCRIPT - -You may find it useful to have a transcript of the commands that the -testsuite sends to GDB, for instance if GDB crashes during the run, -and you want to reconstruct the sequence of commands. - -If the DejaGNU variable TRANSCRIPT is set (to any value), each -invocation of GDB during the test run will get a transcript file -written into the DejaGNU output directory. The file will have the -name transcript., where is an integer. The first line of the -file shows the invocation command with all the options passed to it, -while subsequent lines are the GDB commands. A `make check' might -look like this: - - make check RUNTESTFLAGS=TRANSCRIPT=y - -The transcript may not be complete, as for instance tests of command -completion may show only partial command lines. - GDB By default, the testsuite exercises the GDB in the build directory, diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index cbf8d29ec12..3ff4040d373 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5953,53 +5953,6 @@ proc relative_filename {root full} { return [eval file join [lrange $full_split $len end]] } -# Log gdb command line and script if requested. -if {[info exists TRANSCRIPT]} { - rename send_gdb real_send_gdb - rename remote_spawn real_remote_spawn - rename remote_close real_remote_close - - global gdb_transcript - set gdb_transcript "" - - global gdb_trans_count - set gdb_trans_count 1 - - proc remote_spawn {args} { - global gdb_transcript gdb_trans_count outdir - - if {$gdb_transcript != ""} { - close $gdb_transcript - } - set gdb_transcript [open [file join $outdir transcript.$gdb_trans_count] w] - puts $gdb_transcript [lindex $args 1] - incr gdb_trans_count - - return [uplevel real_remote_spawn $args] - } - - proc remote_close {args} { - global gdb_transcript - - if {$gdb_transcript != ""} { - close $gdb_transcript - set gdb_transcript "" - } - - return [uplevel real_remote_close $args] - } - - proc send_gdb {args} { - global gdb_transcript - - if {$gdb_transcript != ""} { - puts -nonewline $gdb_transcript [lindex $args 0] - } - - return [uplevel real_send_gdb $args] - } -} - # If GDB_PARALLEL exists, then set up the parallel-mode directories. if {[info exists GDB_PARALLEL]} { if {[is_remote host]} {