[FYI] Add completion for Ada catch commands
Commit Message
This patch adds a completion function to the "catch exception"
and "catch handlers" commands.
Tested on x86-64 Fedora 29; reviewed off-list by Joel.
gdb/ChangeLog
2019-05-10 Tom Tromey <tromey@adacore.com>
* ada-lang.c (catch_ada_completer): New function.
(_initialize_ada_language): Use it.
gdb/testsuite/ChangeLog
2019-05-10 Tom Tromey <tromey@adacore.com>
* gdb.ada/info_exc.exp: Add "complete" test.
---
gdb/ChangeLog | 5 +++++
gdb/ada-lang.c | 20 ++++++++++++++++++--
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.ada/info_exc.exp | 4 ++++
4 files changed, 31 insertions(+), 2 deletions(-)
@@ -13342,6 +13342,22 @@ catch_ada_handlers_command (const char *arg_entry, int from_tty,
from_tty);
}
+/* Completion function for the Ada "catch" commands. */
+
+static void
+catch_ada_completer (struct cmd_list_element *cmd, completion_tracker &tracker,
+ const char *text, const char *word)
+{
+ std::vector<ada_exc_info> exceptions = ada_exceptions_list (NULL);
+
+ for (const ada_exc_info &info : exceptions)
+ {
+ if (startswith (info.name, word))
+ tracker.add_completion
+ (gdb::unique_xmalloc_ptr<char> (xstrdup (info.name)));
+ }
+}
+
/* Split the arguments specified in a "catch assert" command.
ARGS contains the command's arguments (or the empty string if
@@ -14562,7 +14578,7 @@ termination).\n\
Otherwise, the catchpoint only stops when the name of the exception being\n\
raised is the same as ARG."),
catch_ada_exception_command,
- NULL,
+ catch_ada_completer,
CATCH_PERMANENT,
CATCH_TEMPORARY);
@@ -14570,7 +14586,7 @@ raised is the same as ARG."),
Catch Ada exceptions, when handled.\n\
With an argument, catch only exceptions with the given name."),
catch_ada_handlers_command,
- NULL,
+ catch_ada_completer,
CATCH_PERMANENT,
CATCH_TEMPORARY);
add_catch_command ("assert", _("\
@@ -49,3 +49,7 @@ gdb_test "info exceptions const.aint" \
"constraint_error: $hex" \
"const.aint_global_gdb_e: $hex"]
+foreach cmd {exception handlers} {
+ gdb_test "complete catch $cmd const.a" \
+ "catch $cmd const.aint_global_gdb_e"
+}