Patchwork Move nptl/tst-eintr1 to xtests

login
register
mail settings
Submitter Szabolcs Nagy
Date May 8, 2019, 3:37 p.m.
Message ID <d14ad1a3-6fef-f606-5e90-a10db99bf4be@arm.com>
Download mbox | patch
Permalink /patch/32605/
State New
Headers show

Comments

Szabolcs Nagy - May 8, 2019, 3:37 p.m.
Don't run nptl/tst-eintr1 by normal make check because it can spuriously
break testing on various linux kernels. (Currently this affects the
aarch64 glibc buildbot machine which regularly fails and loses test
results.)

is it OK to commit?
(i plan to close the bug 24537 if this is accepted, because the main
issue for me is randomly losing make check results and the underlying
bug is in linux)

2019-05-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>

	[BZ #24537]
	* nptl/Makefile: Move tst-eintr1 to xtests.
Florian Weimer - May 8, 2019, 3:41 p.m.
* Szabolcs Nagy:

> 	[BZ #24537]
> 	* nptl/Makefile: Move tst-eintr1 to xtests.

I'm fine with this.

Thanks,
Florian
Szabolcs Nagy - May 9, 2019, 3:57 p.m.
On 08/05/2019 16:41, Florian Weimer wrote:
> * Szabolcs Nagy:

> 

>> 	[BZ #24537]

>> 	* nptl/Makefile: Move tst-eintr1 to xtests.

> 

> I'm fine with this.


thanks, i committed this now in the absence of other comments.

Patch

diff --git a/nptl/Makefile b/nptl/Makefile

index f9bc5cc887..de312b3477 100644

--- a/nptl/Makefile

+++ b/nptl/Makefile

@@ -272,7 +272,7 @@  tests = tst-attr1 tst-attr2 tst-attr3 tst-default-attr \

 	tst-join1 tst-join2 tst-join3 tst-join4 tst-join5 tst-join6 tst-join7 \
 	tst-join8 tst-join9 \
 	tst-detach1 \
-	tst-eintr1 tst-eintr2 tst-eintr3 tst-eintr4 tst-eintr5 \

+	tst-eintr2 tst-eintr3 tst-eintr4 tst-eintr5 \

 	tst-tsd1 tst-tsd2 tst-tsd3 tst-tsd4 tst-tsd5 tst-tsd6 \
 	tst-tls1 tst-tls2 \
 	tst-fork1 tst-fork2 tst-fork3 tst-fork4 \
@@ -330,6 +330,11 @@  tests-internal := tst-rwlock19 tst-rwlock20 \

 
 xtests = tst-setuid1 tst-setuid1-static tst-setuid2 \
 	tst-mutexpp1 tst-mutexpp6 tst-mutexpp10
+

+# This test can run into task limits because of a linux kernel bug

+# and then cause the make process to fail too, see bug 24537.

+xtests += tst-eintr1

+

 test-srcs = tst-oddstacklimit
 
 # Test expected to fail on most targets (except x86_64) due to bug