Patchwork [RFC,gdb/testsuite] Add readnow.exp

login
register
mail settings
Submitter Tom de Vries
Date May 3, 2019, 4:33 p.m.
Message ID <20190503163331.GA14919@delia>
Download mbox | patch
Permalink /patch/32497/
State New
Headers show

Comments

Tom de Vries - May 3, 2019, 4:33 p.m.
Hi,

Looking at:
- PR24517 - "DW_AT_main_subprogram ignored with readnow"
- PR24521 - "readnow failures"
I get the impression that -readnow support is suffering from the fact that
it's not on by default.

I wonder if it makes sense to add a target board to test -readnow.

Any comments?

Thanks,
- Tom

[gdb/testsuite] Add readnow.exp

gdb/testsuite/ChangeLog:

2019-05-03  Tom de Vries  <tdevries@suse.de>

	* boards/readnow.exp: New file.

---
 gdb/testsuite/boards/readnow.exp | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
Tom de Vries - June 11, 2019, 7:45 a.m.
On 03-05-19 18:33, Tom de Vries wrote:
> Hi,
> 
> Looking at:
> - PR24517 - "DW_AT_main_subprogram ignored with readnow"
> - PR24521 - "readnow failures"
> I get the impression that -readnow support is suffering from the fact that
> it's not on by default.
> 
> I wonder if it makes sense to add a target board to test -readnow.
> 
> Any comments?
> 

I've looked a bit further through the test results and found more real
problems.

I'm committing this as obvious.

Thanks,
- Tom

> 
> [gdb/testsuite] Add readnow.exp
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-05-03  Tom de Vries  <tdevries@suse.de>
> 
> 	* boards/readnow.exp: New file.
> 
> ---
>  gdb/testsuite/boards/readnow.exp | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/gdb/testsuite/boards/readnow.exp b/gdb/testsuite/boards/readnow.exp
> new file mode 100644
> index 0000000000..fda60c8a53
> --- /dev/null
> +++ b/gdb/testsuite/boards/readnow.exp
> @@ -0,0 +1,27 @@
> +# Copyright 2019 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +load_board_description "local-board"
> +
> +# Run all tests with -readnow
> +set GDBFLAGS "${GDBFLAGS} -readnow"
> +
> +# This is based on baseboards/unix.exp.
> +# At the moment we only support systems that unix.exp supports.
> +load_generic_config "unix"
> +process_multilib_options ""
> +set found_gcc [find_gcc]
> +set found_gxx [find_g++]
> +set_board_info compiler "$found_gcc"
>

Patch

diff --git a/gdb/testsuite/boards/readnow.exp b/gdb/testsuite/boards/readnow.exp
new file mode 100644
index 0000000000..fda60c8a53
--- /dev/null
+++ b/gdb/testsuite/boards/readnow.exp
@@ -0,0 +1,27 @@ 
+# Copyright 2019 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+load_board_description "local-board"
+
+# Run all tests with -readnow
+set GDBFLAGS "${GDBFLAGS} -readnow"
+
+# This is based on baseboards/unix.exp.
+# At the moment we only support systems that unix.exp supports.
+load_generic_config "unix"
+process_multilib_options ""
+set found_gcc [find_gcc]
+set found_gxx [find_g++]
+set_board_info compiler "$found_gcc"