Patchwork Remove do_set_mallopt_check prototype

login
register
mail settings
Submitter H.J. Lu
Date April 23, 2019, 7:39 p.m.
Message ID <20190423193919.19928-1-hjl.tools@gmail.com>
Download mbox | patch
Permalink /patch/32395/
State New
Headers show

Comments

H.J. Lu - April 23, 2019, 7:39 p.m.
Remove do_set_mallopt_check prototype since it is unused.

	* malloc/arena.c (do_set_mallopt_check): Removed.
---
 malloc/arena.c | 1 -
 1 file changed, 1 deletion(-)
Carlos O'Donell - April 23, 2019, 7:43 p.m.
On 4/23/19 3:39 PM, H.J. Lu wrote:
> Remove do_set_mallopt_check prototype since it is unused.
> 
> 	* malloc/arena.c (do_set_mallopt_check): Removed.
> ---

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

>   malloc/arena.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/malloc/arena.c b/malloc/arena.c
> index 10a77b0232..8340b20b56 100644
> --- a/malloc/arena.c
> +++ b/malloc/arena.c
> @@ -207,7 +207,6 @@ __malloc_fork_unlock_child (void)
>   }
>   
>   #if HAVE_TUNABLES
> -static inline int do_set_mallopt_check (int32_t value);

OK. malloc/malloc.c has the function and uses it there, but we
don't use it here anymore.

>   void
>   TUNABLE_CALLBACK (set_mallopt_check) (tunable_val_t *valp)
>   {
>
DJ Delorie - April 23, 2019, 7:48 p.m.
"H.J. Lu" <hjl.tools@gmail.com> writes:
> 	* malloc/arena.c (do_set_mallopt_check): Removed.

LGTM too
Reviewed-by: DJ Delorie <dj@redhat.com>

Patch

diff --git a/malloc/arena.c b/malloc/arena.c
index 10a77b0232..8340b20b56 100644
--- a/malloc/arena.c
+++ b/malloc/arena.c
@@ -207,7 +207,6 @@  __malloc_fork_unlock_child (void)
 }
 
 #if HAVE_TUNABLES
-static inline int do_set_mallopt_check (int32_t value);
 void
 TUNABLE_CALLBACK (set_mallopt_check) (tunable_val_t *valp)
 {