[RFA,2/8] Handle case where Ada task is current but not listed
Commit Message
Currently, the ravenscar runtime can mark an Ada task as the current
task, before adding it to the list of tasks that can be read by gdb.
In this scenario, gdb can sometimes crash in
ravenscar_get_thread_base_cpu with:
../../src/gdb/ravenscar-thread.c:167: internal-error: int ravenscar_get_thread_base_cpu(ptid_t): Assertion `task_info != NULL' failed.
However, as ravenscar_get_thread_base_cpu is only called to find the
base CPU, we can simply record this when registering the thread, and
look this up later.
gdb/ChangeLog
2019-03-26 Tom Tromey <tromey@adacore.com>
* ravenscar-thread.c (ravenscar_thread_target) <get_base_cpu,
get_base_thread_from_ravenscar_task>: Now methods.
<cpu_map>: New member.
(ravenscar_thread_target::get_thread_base_cpu): Rename from
ravenscar_get_thread_base_cpu. Check cpu_map.
(ravenscar_thread_target::task_is_currently_active): Update.
(ravenscar_thread_target::get_base_thread_from_ravenscar_task):
Now a method.
(ravenscar_thread_target::update_inferior_ptid): Put initial
thread into the cpu_map.
---
gdb/ChangeLog | 13 +++++++++++++
gdb/ravenscar-thread.c | 40 +++++++++++++++++++++++++++++-----------
2 files changed, 42 insertions(+), 11 deletions(-)
@@ -30,6 +30,7 @@
#include "top.h"
#include "regcache.h"
#include "objfiles.h"
+#include <unordered_map>
/* This module provides support for "Ravenscar" tasks (Ada) when
debugging on bare-metal targets.
@@ -132,6 +133,14 @@ private:
ptid_t active_task (int cpu);
bool task_is_currently_active (ptid_t ptid);
bool runtime_initialized ();
+ int get_thread_base_cpu (ptid_t ptid);
+ ptid_t get_base_thread_from_ravenscar_task (ptid_t ptid);
+
+ /* This maps a TID to the CPU on which it was running. This is
+ needed because sometimes the runtime will report an active task
+ that hasn't yet been put on the list of tasks that is read by
+ ada-tasks.c. */
+ std::unordered_map<long, int> cpu_map;
};
/* Return true iff PTID corresponds to a ravenscar task. */
@@ -155,8 +164,8 @@ is_ravenscar_task (ptid_t ptid)
This assume that PTID is a valid ptid_t. Otherwise, a gdb_assert
will be triggered. */
-static int
-ravenscar_get_thread_base_cpu (ptid_t ptid)
+int
+ravenscar_thread_target::get_thread_base_cpu (ptid_t ptid)
{
int base_cpu;
@@ -164,8 +173,15 @@ ravenscar_get_thread_base_cpu (ptid_t ptid)
{
struct ada_task_info *task_info = ada_get_task_info_from_ptid (ptid);
- gdb_assert (task_info != NULL);
- base_cpu = task_info->base_cpu;
+ if (task_info != NULL)
+ base_cpu = task_info->base_cpu;
+ else
+ {
+ auto iter = cpu_map.find (ptid.tid ());
+
+ gdb_assert (iter != cpu_map.end ());
+ base_cpu = iter->second;
+ }
}
else
{
@@ -189,8 +205,7 @@ ravenscar_get_thread_base_cpu (ptid_t ptid)
bool
ravenscar_thread_target::task_is_currently_active (ptid_t ptid)
{
- ptid_t active_task_ptid
- = active_task (ravenscar_get_thread_base_cpu (ptid));
+ ptid_t active_task_ptid = active_task (get_thread_base_cpu (ptid));
return ptid == active_task_ptid;
}
@@ -201,15 +216,15 @@ ravenscar_thread_target::task_is_currently_active (ptid_t ptid)
This is the thread that corresponds to the CPU on which the task
is running. */
-static ptid_t
-get_base_thread_from_ravenscar_task (ptid_t ptid)
+ptid_t
+ravenscar_thread_target::get_base_thread_from_ravenscar_task (ptid_t ptid)
{
int base_cpu;
if (!is_ravenscar_task (ptid))
return ptid;
- base_cpu = ravenscar_get_thread_base_cpu (ptid);
+ base_cpu = get_thread_base_cpu (ptid);
return ptid_t (ptid.pid (), base_cpu, 0);
}
@@ -224,7 +239,7 @@ ravenscar_thread_target::update_inferior_ptid ()
m_base_ptid = inferior_ptid;
gdb_assert (!is_ravenscar_task (inferior_ptid));
- base_cpu = ravenscar_get_thread_base_cpu (m_base_ptid);
+ base_cpu = get_thread_base_cpu (m_base_ptid);
/* If the runtime has not been initialized yet, the inferior_ptid is
the only ptid that there is. */
@@ -240,7 +255,10 @@ ravenscar_thread_target::update_inferior_ptid ()
system.tasking.debug's list yet; so ravenscar_update_thread_list
may not always add it to the thread list. Add it here. */
if (!find_thread_ptid (inferior_ptid))
- add_thread (inferior_ptid);
+ {
+ add_thread (inferior_ptid);
+ cpu_map[inferior_ptid.tid ()] = base_cpu;
+ }
}
/* The Ravenscar Runtime exports a symbol which contains the ID of