Patchwork nss/tst-nss-files-alias-leak: add missing opening quote in printf

login
register
mail settings
Submitter Andreas K. Huettel
Date March 24, 2019, 2:49 p.m.
Message ID <20190324144903.7393-1-dilfridge@gentoo.org>
Download mbox | patch
Permalink /patch/31967/
State New
Headers show

Comments

Andreas K. Huettel - March 24, 2019, 2:49 p.m.
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
---
 nss/tst-nss-files-alias-leak.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Gabriel F. T. Gomes - March 24, 2019, 6:17 p.m.
On Sun, Mar 24 2019, Andreas K. Hüttel wrote:
> Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
> ---
>  nss/tst-nss-files-alias-leak.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nss/tst-nss-files-alias-leak.c b/nss/tst-nss-files-alias-leak.c
> index 4ebe186644..946739bd72 100644
> --- a/nss/tst-nss-files-alias-leak.c
> +++ b/nss/tst-nss-files-alias-leak.c
> @@ -191,7 +191,7 @@ do_test (void)
>            else if (ret != ERANGE)
>              {
>                support_record_failure ();
> -              printf ("error: invalid return code %d (user \%s\", size %zu)\n",
> +              printf ("error: invalid return code %d (user \"%s\", size %zu)\n",
>                        ret, users[id], size);
>              }
>            free (buffer);

Looks obviously correct and I can commit it for you, but I'd like to
remove the signed-off-by statement, as we don't have consensus over
whether we use it in glibc, or not.  Is that alright with you?
Andreas K. Huettel - March 24, 2019, 8:09 p.m.
Am Sonntag, 24. März 2019, 19:17:17 CET schrieb Gabriel F. T. Gomes:
> 
> Looks obviously correct and I can commit it for you, but I'd like to
> remove the signed-off-by statement, as we don't have consensus over
> whether we use it in glibc, or not.  Is that alright with you?

Sure, no problem!
Gabriel F. T. Gomes - March 25, 2019, 3:29 p.m.
On Sun, Mar 24 2019, Andreas K. Huettel wrote:
> 
> Am Sonntag, 24. März 2019, 19:17:17 CET schrieb Gabriel F. T. Gomes:
> > 
> > Looks obviously correct and I can commit it for you, but I'd like to
> > remove the signed-off-by statement, as we don't have consensus over
> > whether we use it in glibc, or not.  Is that alright with you?
> 
> Sure, no problem!

Pushed as 67112f7ae8a3.

Thanks.

Patch

diff --git a/nss/tst-nss-files-alias-leak.c b/nss/tst-nss-files-alias-leak.c
index 4ebe186644..946739bd72 100644
--- a/nss/tst-nss-files-alias-leak.c
+++ b/nss/tst-nss-files-alias-leak.c
@@ -191,7 +191,7 @@  do_test (void)
           else if (ret != ERANGE)
             {
               support_record_failure ();
-              printf ("error: invalid return code %d (user \%s\", size %zu)\n",
+              printf ("error: invalid return code %d (user \"%s\", size %zu)\n",
                       ret, users[id], size);
             }
           free (buffer);