From patchwork Thu Mar 21 02:35:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 31926 Received: (qmail 48491 invoked by alias); 21 Mar 2019 02:36:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 48476 invoked by uid 89); 21 Mar 2019 02:36:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=hits X-HELO: mail-qt1-f196.google.com Return-Path: To: libc-alpha@sourceware.org From: Carlos O'Donell Subject: [PATCH] nscd: Improve nscd.conf comments. Message-ID: <9f46e84e-72f5-afe1-761a-f47fb47ead5f@redhat.com> Date: Wed, 20 Mar 2019 22:35:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 This is another patch that attempts to harmonize Fedora with upstream glibc, and provide some of the same warnings and notes that we have no our nscd.conf file. I think the note about 'shared' and cache hit rates is particularly relevant, and we've had users asking us about this for years. 8< --- 8< --- 8< This change adds a warning to nscd.conf about running multiple caching services together and that it may lead to unexpected behaviours. Also we add a note that enabling the 'shared' option will cause cache hit rates to be misreported (a side effect of the implementation). --- ChangeLog | 4 ++++ nscd/nscd.conf | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/ChangeLog b/ChangeLog index 9765ae0160..a7b90cd1a7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2019-03-20 Carlos O'Donell + + * nscd/nscd.conf: Add warning and comment about shared option. + 2019-03-20 Carlos O'Donell * nss/nsswitch.conf: Expand comments, and simplify defaults. diff --git a/nscd/nscd.conf b/nscd/nscd.conf index 39b875912d..ec8a8c1622 100644 --- a/nscd/nscd.conf +++ b/nscd/nscd.conf @@ -3,6 +3,9 @@ # # An example Name Service Cache config file. This file is needed by nscd. # +# WARNING: Running nscd with a secondary caching service like sssd may lead to +# unexpected behaviour, especially with how long entries are cached. +# # Legal entries are: # # logfile @@ -23,6 +26,9 @@ # check-files # persistent # shared +# NOTE: Setting 'shared' to a value of 'yes' will accelerate the lookup +# with the help of the client, but these lookups will not be +# counted as cache hits i.e. 'nscd -g' may show '0%'. # max-db-size # auto-propagate #