From patchwork Thu Mar 14 17:32:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 31853 Received: (qmail 85881 invoked by alias); 14 Mar 2019 17:32:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 85873 invoked by uid 89); 14 Mar 2019 17:32:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 17:32:43 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 1FE492E1C6 for ; Thu, 14 Mar 2019 12:32:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4UDihTUwgdnCe4UDihMwcM; Thu, 14 Mar 2019 12:32:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GI7E/7h5ZbW+rh/cjSv27GGG0BJT6LrJjxVBJY6rLEM=; b=L+rXO9ReLl1Fr8j2DjeNNu4WNT FndCXuSHY7UfsBnkMmnKMGSnx9DsSOxhn+5PvgH18rsl+jdGEZwnjTg6OHOgSdXpiUTem3hJoX0g9 LWPMmwwMDsdqClVXY7pEd9yVl; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:46484 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h4UDh-003Mii-QQ; Thu, 14 Mar 2019 12:32:41 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: GDB 8.2.90 available for testing References: <20190227055112.4A5E782D7B@joel.gnat.com> <835zt3kbjf.fsf@gnu.org> <87k1hae23l.fsf@tromey.com> <835zstbyhb.fsf@gnu.org> <87zhq5f5j3.fsf@tromey.com> <83sgvw8tjv.fsf@gnu.org> Date: Thu, 14 Mar 2019 11:32:40 -0600 In-Reply-To: <83sgvw8tjv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Mar 2019 08:12:52 +0200") Message-ID: <878sxhfjk7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 >>>>> "Eli" == Eli Zaretskii writes: >> From: Tom Tromey >> Cc: Tom Tromey , palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org >> Date: Fri, 08 Mar 2019 13:57:36 -0700 >> >> I have played with the "nonl" code a bit and I can't seem to find an >> approach that fixes this. We may have to revert that patch :( Eli> Maybe we should ask on bug-ncurses@gnu.org, perhaps Thomas Dickey will Eli> have some suggestion for dealing with this? If the only solution is Eli> to revert, we have nothing to lose, I think. The appended patch seems to work ok for me, at the cost of leaving the gdb prompt in the TUI console window. Tom diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c index ef1e88507aa..f3eb2273e6b 100644 --- a/gdb/tui/tui-io.c +++ b/gdb/tui/tui-io.c @@ -631,7 +631,7 @@ gdb_wgetch (WINDOW *win) after the command. So, if we read \r, emit a \r now, after nl mode has been re-entered, so that the output looks correct. */ if (r == '\r') - puts ("\r"); + waddch (win, '\n'); return r; }