Patchwork [PUSHED,OBV] The NEWS file had two "New targets" sections for 8.3.

login
register
mail settings
Submitter John Baldwin
Date March 12, 2019, 9 p.m.
Message ID <20190312210028.47955-1-jhb@FreeBSD.org>
Download mbox | patch
Permalink /patch/31832/
State New
Headers show

Comments

John Baldwin - March 12, 2019, 9 p.m.
gdb/ChangeLog:

	* NEWS: Combine separate "New targets" sections for 8.3.
---
 gdb/ChangeLog | 4 ++++
 gdb/NEWS      | 7 ++-----
 2 files changed, 6 insertions(+), 5 deletions(-)
John Baldwin - March 12, 2019, 9:09 p.m.
On 3/12/19 2:00 PM, John Baldwin wrote:
> gdb/ChangeLog:
> 
> 	* NEWS: Combine separate "New targets" sections for 8.3.

Ok for the 8.3 branch?

> ---
>  gdb/ChangeLog | 4 ++++
>  gdb/NEWS      | 7 ++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index fe7504c27a..eea9ecfde9 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2019-03-12  John Baldwin  <jhb@FreeBSD.org>
> +
> +	* NEWS: Combine separate "New targets" sections for 8.3.
> +
>  2019-03-12  John Baldwin  <jhb@FreeBSD.org>
>  
>  	* ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
> diff --git a/gdb/NEWS b/gdb/NEWS
> index cc7c35c064..88ce9a7104 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -55,11 +55,6 @@
>  * Removed support for old demangling styles arm, edg, gnu, hp and
>    lucid.
>  
> -* New targets
> -
> -  NXP S12Z		s12z-*-elf
> -  GNU/Linux/OpenRISC	or1k*-*-linux*
> -
>  * New commands
>  
>  set debug compile-cplus-types
> @@ -187,6 +182,8 @@ GNU/Linux/RISC-V		riscv*-*-linux*
>  CSKY ELF			csky*-*-elf
>  CSKY GNU/LINUX			csky*-*-linux
>  FreeBSD/riscv			riscv*-*-freebsd*
> +NXP S12Z			s12z-*-elf
> +GNU/Linux/OpenRISC		or1k*-*-linux*
>  
>  * Removed targets
>  
>
Rainer Orth - March 12, 2019, 9:12 p.m.
John Baldwin <jhb@FreeBSD.org> writes:

> diff --git a/gdb/NEWS b/gdb/NEWS
> index cc7c35c064..88ce9a7104 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -55,11 +55,6 @@
>  * Removed support for old demangling styles arm, edg, gnu, hp and
>    lucid.
>  
> -* New targets
> -
> -  NXP S12Z		s12z-*-elf
> -  GNU/Linux/OpenRISC	or1k*-*-linux*
> -
>  * New commands
>  
>  set debug compile-cplus-types
> @@ -187,6 +182,8 @@ GNU/Linux/RISC-V		riscv*-*-linux*
>  CSKY ELF			csky*-*-elf
>  CSKY GNU/LINUX			csky*-*-linux
>  FreeBSD/riscv			riscv*-*-freebsd*
> +NXP S12Z			s12z-*-elf
> +GNU/Linux/OpenRISC		or1k*-*-linux*

Shouldn't they be sorted alphabetically, either by name or target
triplet?

	Rainer
John Baldwin - March 12, 2019, 9:53 p.m.
On 3/12/19 2:12 PM, Rainer Orth wrote:
> John Baldwin <jhb@FreeBSD.org> writes:
> 
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index cc7c35c064..88ce9a7104 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -55,11 +55,6 @@
>>  * Removed support for old demangling styles arm, edg, gnu, hp and
>>    lucid.
>>  
>> -* New targets
>> -
>> -  NXP S12Z		s12z-*-elf
>> -  GNU/Linux/OpenRISC	or1k*-*-linux*
>> -
>>  * New commands
>>  
>>  set debug compile-cplus-types
>> @@ -187,6 +182,8 @@ GNU/Linux/RISC-V		riscv*-*-linux*
>>  CSKY ELF			csky*-*-elf
>>  CSKY GNU/LINUX			csky*-*-linux
>>  FreeBSD/riscv			riscv*-*-freebsd*
>> +NXP S12Z			s12z-*-elf
>> +GNU/Linux/OpenRISC		or1k*-*-linux*
> 
> Shouldn't they be sorted alphabetically, either by name or target
> triplet?

In the past few releases they've just been in "as-added" order.  Sorting
by some other thing seems fine to me, but I'll defer to the maintainers
on what key to use.
Joel Brobecker - March 14, 2019, 6:52 a.m.
> > gdb/ChangeLog:
> > 
> > 	* NEWS: Combine separate "New targets" sections for 8.3.
> 
> Ok for the 8.3 branch?

Absolutely :).

Thanks John.

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fe7504c27a..eea9ecfde9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2019-03-12  John Baldwin  <jhb@FreeBSD.org>
+
+	* NEWS: Combine separate "New targets" sections for 8.3.
+
 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 
 	* ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
diff --git a/gdb/NEWS b/gdb/NEWS
index cc7c35c064..88ce9a7104 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -55,11 +55,6 @@ 
 * Removed support for old demangling styles arm, edg, gnu, hp and
   lucid.
 
-* New targets
-
-  NXP S12Z		s12z-*-elf
-  GNU/Linux/OpenRISC	or1k*-*-linux*
-
 * New commands
 
 set debug compile-cplus-types
@@ -187,6 +182,8 @@  GNU/Linux/RISC-V		riscv*-*-linux*
 CSKY ELF			csky*-*-elf
 CSKY GNU/LINUX			csky*-*-linux
 FreeBSD/riscv			riscv*-*-freebsd*
+NXP S12Z			s12z-*-elf
+GNU/Linux/OpenRISC		or1k*-*-linux*
 
 * Removed targets