From patchwork Mon Mar 11 20:15:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 31818 Received: (qmail 118922 invoked by alias); 11 Mar 2019 20:15:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118862 invoked by uid 89); 11 Mar 2019 20:15:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:83pnr08, HX-Languages-Length:1125, Enter, righthand X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Mar 2019 20:15:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DBE8A56107; Mon, 11 Mar 2019 16:15:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tOC-YXjBSP-0; Mon, 11 Mar 2019 16:15:37 -0400 (EDT) Received: from murgatroyd (75-166-85-218.hlrn.qwest.net [75.166.85.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 6933056104; Mon, 11 Mar 2019 16:15:37 -0400 (EDT) From: Tom Tromey To: Eli Zaretskii Cc: tromey@adacore.com, gdb-patches@sourceware.org Subject: Re: [RFC 8.3 0/3] Some style fixes References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> Date: Mon, 11 Mar 2019 14:15:36 -0600 In-Reply-To: <83zhq26fcw.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Mar 2019 15:14:39 +0200") Message-ID: <874l899nh3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Eli> However, the artifacts I saw in the TUI display in the Eli> pretest are still there. In particular, the right-hand side of the Eli> frame of the source window still gets overwritten when stepping Eli> through the inferior's code, and it looks like the newline is not Eli> echoed after commands typed in the command window. I wonder if this is the "nonl" bug. You can test that theory by applying the appended. Tom diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c index d006e41cabb..b25b55b8515 100644 --- a/gdb/tui/tui-io.c +++ b/gdb/tui/tui-io.c @@ -606,15 +606,15 @@ tui_mld_beep (const struct match_list_displayer *displayer) static int gdb_wgetch (WINDOW *win) { - nonl (); + /* nonl (); */ int r = wgetch (win); - nl (); + /* nl (); */ /* In nonl mode, if the user types Enter, it will not be echoed properly. This will result in gdb output appearing immediately after the command. So, if we read \r, emit a \r now, after nl mode has been re-entered, so that the output looks correct. */ - if (r == '\r') - puts ("\r"); + /* if (r == '\r') */ + /* puts ("\r"); */ return r; }