Patchwork [PUSHED_OBVIOUS] Ensure 'help set/show print inferior-events' shows the example events.

login
register
mail settings
Submitter Philippe Waroquiers
Date March 9, 2019, 11:28 a.m.
Message ID <20190309112828.19450-1-philippe.waroquiers@skynet.be>
Download mbox | patch
Permalink /patch/31798/
State New
Headers show

Comments

Philippe Waroquiers - March 9, 2019, 11:28 a.m.
Without this patch, the help stops after  'e.g.' :
  (gdb) apropos \(inferior\|thread\) event
  set print inferior-events -- Set printing of inferior events (e.g.
  set print thread-events -- Set printing of thread events (such as thread start and exit)
  show print inferior-events -- Show printing of inferior events (e.g.
  show print thread-events -- Show printing of thread events (such as thread start and exit)

Using the same notation as for the thread evenets (i.e. 'such as') gives:
 (gdb) apropos \(inferior\|thread\) event
 set print inferior-events -- Set printing of inferior events (such as inferior start and exit)
 set print thread-events -- Set printing of thread events (such as thread start and exit)
 show print inferior-events -- Show printing of inferior events (such as inferior start and exit)
 show print thread-events -- Show printing of thread events (such as thread start and exit)
---
 gdb/ChangeLog  | 5 +++++
 gdb/inferior.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)
Eli Zaretskii - March 9, 2019, 1:57 p.m.
> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sat,  9 Mar 2019 12:28:28 +0100
> 
> Without this patch, the help stops after  'e.g.' :
>   (gdb) apropos \(inferior\|thread\) event
>   set print inferior-events -- Set printing of inferior events (e.g.

Thanks, I think perhaps the ari script should flag such blunders.

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bb10c7d447..77bad3830c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+	* inferior.c (initialize_inferiors): Ensure 'help set/show print
+	inferior-events' shows the example events.
+
 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 
 	Support styling on native MS-Windows console
diff --git a/gdb/inferior.c b/gdb/inferior.c
index b13d8f3bff..cb8063ba03 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -930,8 +930,8 @@  The new inferior ID must be currently known."),
 
   add_setshow_boolean_cmd ("inferior-events", no_class,
          &print_inferior_events, _("\
-Set printing of inferior events (e.g., inferior start and exit)."), _("\
-Show printing of inferior events (e.g., inferior start and exit)."), NULL,
+Set printing of inferior events (such as inferior start and exit)."), _("\
+Show printing of inferior events (such as inferior start and exit)."), NULL,
          NULL,
          show_print_inferior_events,
          &setprintlist, &showprintlist);