diff mbox

[v4] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

Message ID 20190307094002.16972-1-felixonmars@archlinux.org
State Committed
Headers

Commit Message

Felix Yan March 7, 2019, 9:40 a.m. UTC 
  Minguo calendar is the official calendar system, and very widely used in
Taiwan. This commit adds its support into glibc.

Some background information: The government website (www.gov.tw) uses it,
popular public services like Taiwan HSR also use this calendar system.

Link to Wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

        [BZ #24293]
        * localedata/locales/zh_TW (era): Add, support Minguo calendar.
        * localedata/locales/cmn_TW (era): Likewise.
        * localedata/locales/hak_TW (era): Likewise.
        * localedata/locales/lzh_TW (era): Likewise.
        * localedata/locales/nan_TW (era): Likewise.
---
 localedata/locales/cmn_TW | 4 ++++
 localedata/locales/hak_TW | 4 ++++
 localedata/locales/lzh_TW | 4 ++++
 localedata/locales/nan_TW | 4 ++++
 localedata/locales/zh_TW  | 4 ++++
 5 files changed, 20 insertions(+)

Comments

Rafal Luzynski March 8, 2019, 10:52 a.m. UTC | #1 
7.03.2019 10:40 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan. This commit adds its support into glibc.
> 
> Some background information: The government website (www.gov.tw) uses it,
> popular public services like Taiwan HSR also use this calendar system.
> 
> Link to Wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar
> 
>         [BZ #24293]
>         * localedata/locales/zh_TW (era): Add, support Minguo calendar.
>         * localedata/locales/cmn_TW (era): Likewise.
>         * localedata/locales/hak_TW (era): Likewise.
>         * localedata/locales/lzh_TW (era): Likewise.
>         * localedata/locales/nan_TW (era): Likewise.

This patch is correct, thank you.

Reviewed-by: Rafal Luzynski <digitalfreak@lingonborough.com>

Do you need someone to push it for you?

Questions to more experienced maintainers:

* Have you got any objections against this patch?
* Do we need a NEWS entry for this change?

Mike, Joseph, Carlos, anyone?

Regards,

Rafal
Felix Yan March 8, 2019, 11:03 a.m. UTC | #2 
On 2019/3/8 下午6:52, Rafal Luzynski wrote:
> Do you need someone to push it for you?

Yes. Sorry I am not sure about the process here.
Rafal Luzynski March 11, 2019, 11:05 a.m. UTC | #3 
8.03.2019 12:03 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> On 2019/3/8 下午6:52, Rafal Luzynski wrote:
> > Do you need someone to push it for you?
> 
> Yes. Sorry I am not sure about the process here.

The process you have followed is absolutely correct, as long as
you contribute to locale data or if your patch is trivial.
If you wanted to contribute to other parts, then you would have
to sign the copyright assignment. But for now it is correct,
locale data are not copyrighted. Someone (most probably myself)
will push this for you shortly.

Regards,

Rafal
Rafal Luzynski March 15, 2019, 9:20 a.m. UTC | #4 
11.03.2019 12:05 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> [...] Someone (most probably myself)
> will push this for you shortly.

This patch [1] has just been pushed to master with minor reword of
the subject line reflecting the fact that not just zh_TW but also
other Taiwanese locales have been updated.  Thank you Felix for your
contribution.  Feel free to contribute more patches if you have more
updates, especially for nan_TW@latin which is not yet updated.

Regards,

Rafal


[1] https://sourceware.org/ml/libc-alpha/2019-03/msg00135.html
diff mbox

Patch

diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
index cca7cc19af..9d9aca0f9e 100644
--- a/localedata/locales/cmn_TW
+++ b/localedata/locales/cmn_TW
@@ -119,6 +119,10 @@  am_pm         "<U4E0A><U5348>";/
 t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Y年 %b %-d號 %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/hak_TW b/localedata/locales/hak_TW
index f62937e91b..ec86e985d1 100644
--- a/localedata/locales/hak_TW
+++ b/localedata/locales/hak_TW
@@ -116,6 +116,10 @@  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Yå¹´ %b %eæ—¥ %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %e<U65E5> %A %H:%M:%S %Z"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/lzh_TW b/localedata/locales/lzh_TW
index 9654463d42..4740418a83 100644
--- a/localedata/locales/lzh_TW
+++ b/localedata/locales/lzh_TW
@@ -150,6 +150,10 @@  alt_digits    "<U3007>";/
             "<U5345><U4E00>"
 %
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/nan_TW b/localedata/locales/nan_TW
index f5bc5d1642..0f19c66c86 100644
--- a/localedata/locales/nan_TW
+++ b/localedata/locales/nan_TW
@@ -117,6 +117,10 @@  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
 % %Yå¹´ %b %eæ—¥ %A %H:%M:%S %Z
 date_fmt      "%Y<U5E74> %b %e<U65E5> %A %H:%M:%S %Z"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_NUMERIC
diff --git a/localedata/locales/zh_TW b/localedata/locales/zh_TW
index 92b04b083d..b869dec317 100644
--- a/localedata/locales/zh_TW
+++ b/localedata/locales/zh_TW
@@ -126,6 +126,10 @@  am_pm	"<U4E0A><U5348>";"<U4E0B><U5348>"
 % t_fmt_ampm: "%p %I<h>%M<m>%S<s>"
 t_fmt_ampm  "%p %I<U6642>%M<U5206>%S<U79D2>"
 week 7;19971130;1
+
+era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
+    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
+    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
 END LC_TIME
 
 LC_MESSAGES