Message ID | 0da7933d5fb99c0c390acb5482cdcde7@polymtl.ca |
---|---|
State | New, archived |
Headers |
Received: (qmail 17837 invoked by alias); 9 Jan 2019 15:59:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 17817 invoked by uid 89); 9 Jan 2019 15:59:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=formats X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 15:59:22 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x09FxGIc011365 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gdb-patches@sourceware.org>; Wed, 9 Jan 2019 10:59:21 -0500 Received: by simark.ca (Postfix, from userid 112) id 5B4FB1E7BB; Wed, 9 Jan 2019 10:59:16 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 5CB381E4A3; Wed, 9 Jan 2019 10:59:14 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 09 Jan 2019 10:59:14 -0500 From: Simon Marchi <simon.marchi@polymtl.ca> To: Eli Zaretskii <eliz@gnu.org> Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: Remove support for old mangling schemes In-Reply-To: <83h8ehj0wi.fsf@gnu.org> References: <20190108232208.17487-1-simon.marchi@ericsson.com> <20190109045032.2146-1-simon.marchi@polymtl.ca> <83h8ehj0wi.fsf@gnu.org> Message-ID: <0da7933d5fb99c0c390acb5482cdcde7@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes |
Commit Message
Simon Marchi
Jan. 9, 2019, 3:59 p.m. UTC
On 2019-01-09 10:39, Eli Zaretskii wrote: >> From: Simon Marchi <simon.marchi@polymtl.ca> >> Cc: Simon Marchi <simon.marchi@ericsson.com> >> Date: Tue, 8 Jan 2019 23:50:32 -0500 >> >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 4bca933195c9..ffc702937b7a 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -10703,31 +10703,9 @@ or demangled form. >> @cindex symbol decoding style, C@t{++} >> @kindex set demangle-style >> @item set demangle-style @var{style} >> -Choose among several encoding schemes used by different compilers to >> -represent C@t{++} names. The choices for @var{style} are currently: >> - >> -@table @code >> -@item auto >> -Allow @value{GDBN} to choose a decoding style by inspecting your >> program. >> -This is the default. > > Are we removing 'auto' as well? If not, why do we want to un-document > it? I decided to remove the list of possible values and refer to the in-process help, this way we don't have to keep it up to date (as you might notice, the list was incomplete). But since the value "auto" is special, I agree we should mention it. Is it fine if I add this sentence? @item show demangle-style Display the encoding style currently in use for decoding C@t{++} symbols. Simon
Comments
> Date: Wed, 09 Jan 2019 10:59:14 -0500 > From: Simon Marchi <simon.marchi@polymtl.ca> > Cc: gdb-patches@sourceware.org > > > Are we removing 'auto' as well? If not, why do we want to un-document > > it? > > I decided to remove the list of possible values and refer to the > in-process help, this way we don't have to keep it up to date (as you > might notice, the list was incomplete). But since the value "auto" is > special, I agree we should mention it. Is it fine if I add this > sentence? Yes, thanks.
On 2019-01-09 11:14, Eli Zaretskii wrote: >> Date: Wed, 09 Jan 2019 10:59:14 -0500 >> From: Simon Marchi <simon.marchi@polymtl.ca> >> Cc: gdb-patches@sourceware.org >> >> > Are we removing 'auto' as well? If not, why do we want to un-document >> > it? >> >> I decided to remove the list of possible values and refer to the >> in-process help, this way we don't have to keep it up to date (as you >> might notice, the list was incomplete). But since the value "auto" is >> special, I agree we should mention it. Is it fine if I add this >> sentence? > > Yes, thanks. Thanks. I'll just wait for the confirmation from Keith that v2 is ok with him before pushing. Simon
On 1/9/19 8:18 AM, Simon Marchi wrote: > I'll just wait for the confirmation from Keith that v2 is ok with him > before pushing. Absolutely! Please, approve your patch! ;-) Keith
On 2019-01-09 12:02, Keith Seitz wrote: > On 1/9/19 8:18 AM, Simon Marchi wrote: >> I'll just wait for the confirmation from Keith that v2 is ok with him >> before pushing. > Absolutely! Please, approve your patch! ;-) Thanks, it's now pushed. Simon
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index ffc702937b7..4a00834d0bf 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -10705,7 +10705,8 @@ or demangled form. @item set demangle-style @var{style} Choose among several encoding schemes used by different compilers to represent C@t{++} names. If you omit @var{style}, you will see a list of possible -formats. +formats. The default value is @var{auto}, which lets @value{GDBN} choose a +decoding style by inspecting your program.