diff mbox

[v2] en_US: define date_fmt (bug 24046)

Message ID 20190106171929.13106-1-aurelien@aurel32.net
State Committed
Headers

Commit Message

Aurelien Jarno Jan. 6, 2019, 5:19 p.m. UTC 
  The en_US locale use a 12h am/pm format in both d_fmt and d_t_fmt, which
is correct, but does not define date_fmt. This cause the default value
to be used, which is in 24h format.

This patch adds the date_fmt entry to the en_US locale with the same
value as d_t_fmt as the latter already includes the timezone.

Changelog
	[BZ #24046]
	* localedata/locales/en_US (date_fmt): Set to
	"%a %d %b %Y %r %Z".
---
 localedata/locales/en_US | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rafal Luzynski Jan. 7, 2019, 11:04 a.m. UTC | #1 
6.01.2019 18:19 Aurelien Jarno <aurelien@aurel32.net> wrote:
> 
> 
> The en_US locale use a 12h am/pm format in both d_fmt and d_t_fmt, which
> is correct, but does not define date_fmt. This cause the default value
> to be used, which is in 24h format.
> 
> This patch adds the date_fmt entry to the en_US locale with the same
> value as d_t_fmt as the latter already includes the timezone.
> 
> Changelog
> 	[BZ #24046]
> 	* localedata/locales/en_US (date_fmt): Set to
> 	"%a %d %b %Y %r %Z".

Now it does not say that this is a new field.  I would do:

	* localedata/locales/en_US (date_fmt): Add, set to
	"%a %d %b %Y %r %Z".

or

	* localedata/locales/en_US (date_fmt): New field, set to
	"%a %d %b %Y %r %Z".

But maybe I'm expecting too much.  I wonder what more experienced
maintainers think about it.

Otherwise the patch looks perfect to me and Siddhesh also said it's
OK for master so... please commit with the change as suggested above
(or without that change if you don't agree).

Thanks,

Rafal
Aurelien Jarno Jan. 7, 2019, 1:58 p.m. UTC | #2 
Hi,

On 2019-01-07 12:04, Rafal Luzynski wrote:
> 6.01.2019 18:19 Aurelien Jarno <aurelien@aurel32.net> wrote:
> > 
> > 
> > The en_US locale use a 12h am/pm format in both d_fmt and d_t_fmt, which
> > is correct, but does not define date_fmt. This cause the default value
> > to be used, which is in 24h format.
> > 
> > This patch adds the date_fmt entry to the en_US locale with the same
> > value as d_t_fmt as the latter already includes the timezone.
> > 
> > Changelog
> > 	[BZ #24046]
> > 	* localedata/locales/en_US (date_fmt): Set to
> > 	"%a %d %b %Y %r %Z".
> 
> Now it does not say that this is a new field.  I would do:
> 
> 	* localedata/locales/en_US (date_fmt): Add, set to
> 	"%a %d %b %Y %r %Z".

I have just committed it with the above change.

Regards,
Aurelien
Rafal Luzynski Jan. 8, 2019, 11:21 p.m. UTC | #3 
7.01.2019 14:58 Aurelien Jarno <aurelien@aurel32.net> wrote:
> [...]
> I have just committed it with the above change.

Thank you so much.

Regards,

Rafal
diff mbox

Patch

diff --git a/localedata/locales/en_US b/localedata/locales/en_US
index 5e2b365659..7a3f5dc778 100644
--- a/localedata/locales/en_US
+++ b/localedata/locales/en_US
@@ -117,6 +117,9 @@  t_fmt   "%r"
 % Appropriate AM/PM time representation (%r)
 t_fmt_ampm "%I:%M:%S %p"
 %
+% Appropriate date and time representation for date(1)
+date_fmt "%a %d %b %Y %r %Z"
+%
 % Strings for AM/PM
 %
 am_pm	"AM";"PM"