From patchwork Fri Dec 21 18:55:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 30801 Received: (qmail 110699 invoked by alias); 21 Dec 2018 18:55:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 110666 invoked by uid 89); 21 Dec 2018 18:55:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*fr, sparcv9 X-HELO: relay1.mentorg.com Date: Fri, 21 Dec 2018 18:55:04 +0000 From: Joseph Myers To: "H.J. Lu" CC: "Albert ARIBAUD (3ADEV)" , GNU C Library Subject: Re: [PATCH v5] Y2038: make __difftime compatible with 64-bit time In-Reply-To: Message-ID: References: <20181220204041.9377-1-albert.aribaud@3adev.fr> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 On Fri, 21 Dec 2018, H.J. Lu wrote: > This caused: > > https://sourceware.org/bugzilla/show_bug.cgi?id=24023 I am testing this patch and will commit if the tests pass. Update nios2, sparc32 localplt.data for difftime changes (bug 24023). The recent difftime changes introduced localplt test failures on nios2 and sparc32, two configurations where some soft-fp functions are defined in / exported from libc.so, and where the difftime changes affected the particular set of floating-point operations used in libc.so. This patch adds those functions to localplt.data, alongside other such functions already there. (In the sparc32 case, and more generally on any platform where long double is a software floating-point type, it would probably be more efficient to avoid using long double at all in difftime, but that's a pre-existing issue.) Tested with build-many-glibcs.py for its nios2 and sparcv9 configurations. 2018-12-21 Joseph Myers [BZ #24023] * sysdeps/unix/sysv/linux/nios2/localplt.data: Allow __floatundidf PLT reference in libc.so. * sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data: Allow _Q_lltoq and _Q_qtod PLT references in libc.so. diff --git a/sysdeps/unix/sysv/linux/nios2/localplt.data b/sysdeps/unix/sysv/linux/nios2/localplt.data index 4430a5891e..3805ed56b9 100644 --- a/sysdeps/unix/sysv/linux/nios2/localplt.data +++ b/sysdeps/unix/sysv/linux/nios2/localplt.data @@ -26,6 +26,7 @@ libc.so: __divsf3 libc.so: __nedf2 libc.so: __eqdf2 libc.so: __extendsfdf2 +libc.so: __floatundidf ? libm.so: matherr # The main malloc is interposed into the dynamic linker, for # allocations after the initial link (when dlopen is used). diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data b/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data index 1668f4017e..6bf10ff858 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data @@ -8,8 +8,10 @@ libc.so: _Q_fle ? libc.so: _Q_flt ? libc.so: _Q_fne ? libc.so: _Q_itoq ? +libc.so: _Q_lltoq ? libc.so: _Q_mul ? libc.so: _Q_sub ? +libc.so: _Q_qtod ? libc.so: _Unwind_Find_FDE libc.so: calloc libc.so: free