Message ID | 30919bd86dea123f624ccd1f069aff432622fb6e.camel@aegee.org |
---|---|
State | New, archived |
Headers |
Received: (qmail 96038 invoked by alias); 5 Dec 2018 07:23:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 96004 invoked by uid 89); 5 Dec 2018 07:23:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HAuthentication-Results:auth, HAuthentication-Results:smtp.auth X-HELO: mail.aegee.org Received: from mail.aegee.org (HELO mail.aegee.org) (144.76.142.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Dec 2018 07:23:13 +0000 Authentication-Results: mail.aegee.org/wB57Mu0k024858; auth=pass (PLAIN) smtp.auth=didopalauzov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1543994583; i=dkim+MSA-tls@aegee.org; r=y; bh=p2gUI0Zz36HLhrGoRICp0oZezCx54i/aFJllLN9TRFU=; h=Subject:From:To:Date; b=f9/FrvCpqNG55D9STCL8hJce7bvE7VJOB/NKoqAWD6Ok3s6ObNZ7LZUFTuSZS2M6i U81E3PNKPtY4RKnejWpVmf5LjVRPwV70mWHT4gsyEBNETpHyYKI2FXHMSUHQHCx9wW s9vv3XlnXOILZjPBHJyz+W0Wmypn1eO2YaAEd/4Vc2v169JYNieMp2yYveExbE9tXu 1cfO3I8Ke57Y0SP0rZk0zfCmdI9UEToKUOx/cxvs7hXvio+LvKM2KyjjrGHjrDdb4g J7ZeuKLqXM0MzGwgVj+z2TIyR71ScykQznXhFq31Gfoj1CYiLURbZGkiomlLDDznah kUB3CVTcfkoz4XQbimR+E8HOcf55tgSWwrwEaYQNFaHqDkyORf2VgFNAkdakk2CbJC a6AinC6sSWnPN9qNDHl0qb15JvCfPqZoF8SkvmOhLCkDb+3Fns2g3kC/gL6Zxze+DN IKH93KAazapBULeC3Ms0omUAYejJ/zmnq3HFoOUZhAy3tiudJgm5aD+8ybV967eFWu TNnQMbsZZJpVHXxc2VawCrtRhULwdatsu1ag0IqlEWLyX6CWyOv8T2WzVXx8afGCCf R4Pi152Y95jdWcmzd8YS2MvDv0fcZ3BUOcG8d9ntQgP8xp9xt+X44csSdFA1d4SswM 0BiAevfFRJYs3FRvAMtXhqQM= Authentication-Results: mail.aegee.org/wB57Mu0k024858; dkim=none Received: from Tylan (37-219-194-104.nat.bb.dnainternet.fi [37.219.194.104]) (authenticated bits=0) by mail.aegee.org (8.15.2/8.15.2) with ESMTPSA id wB57Mu0k024858 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <gdb-patches@sourceware.org>; Wed, 5 Dec 2018 07:22:59 GMT Message-ID: <30919bd86dea123f624ccd1f069aff432622fb6e.camel@aegee.org> Subject: Linking gdb with -ltinfow, if libtinfo is not available From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= <dilyan.palauzov@aegee.org> To: gdb-patches@sourceware.org Date: Wed, 05 Dec 2018 07:22:56 +0000 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.31.3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes |
Commit Message
Дилян Палаузов
Dec. 5, 2018, 7:22 a.m. UTC
See https://sourceware.org/bugzilla/show_bug.cgi?id=23950 for details. CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
Comments
On 2018-12-05 02:22, Дилян Палаузов wrote: > See https://sourceware.org/bugzilla/show_bug.cgi?id=23950 for details. > > diff --git a/gdb/configure.ac b/gdb/configure.ac > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -592,7 +592,7 @@ case $host_os in > esac > > # These are the libraries checked by Readline. > -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) > +AC_SEARCH_LIBS(tgetent, [termcap tinfo tinfow curses ncursesw > ncurses]) > > if test "$ac_cv_search_tgetent" = no; then > CONFIG_OBS="$CONFIG_OBS stub-termcap.o" I am not able to test this (since all my systems have a libtinfo.so, which gets picked up), but I think it makes sense. If you have a system where the only ncurses available is configured with: --with-termlib --with-shared --enable-widec you end up with libtinfow.so and no libtinfo.so. Any objections? I can take care of ChangeLog and commit message since it is a very small change, but next time please make sure to follow the checklist [1]. Thanks, Simon [1] https://sourceware.org/gdb/wiki/ContributionChecklist
Hello, you should be able to test this by having libtinfo.so in a directory, that is not introduced to the linker by -L and is not default for the compiller or linker and have libtinfow.so in а path passed by -L; possibly moving libtinfo.so to a location that is still considered by ldconfig. Regards Дилян On Wed, 2018-12-05 at 09:49 -0500, Simon Marchi wrote: > On 2018-12-05 02:22, Дилян Палаузов wrote: > > See https://sourceware.org/bugzilla/show_bug.cgi?id=23950 for details. > > > > diff --git a/gdb/configure.ac b/gdb/configure.ac > > --- a/gdb/configure.ac > > +++ b/gdb/configure.ac > > @@ -592,7 +592,7 @@ case $host_os in > > esac > > > > # These are the libraries checked by Readline. > > -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) > > +AC_SEARCH_LIBS(tgetent, [termcap tinfo tinfow curses ncursesw > > ncurses]) > > > > if test "$ac_cv_search_tgetent" = no; then > > CONFIG_OBS="$CONFIG_OBS stub-termcap.o" > > I am not able to test this (since all my systems have a libtinfo.so, > which gets picked up), but I think it makes sense. If you have a system > where the only ncurses available is configured with: > > --with-termlib --with-shared --enable-widec > > you end up with libtinfow.so and no libtinfo.so. Any objections? I can > take care of ChangeLog and commit message since it is a very small > change, but next time please make sure to follow the checklist [1]. > > Thanks, > > Simon > > [1] https://sourceware.org/gdb/wiki/ContributionChecklist
diff --git a/gdb/configure.ac b/gdb/configure.ac --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -592,7 +592,7 @@ case $host_os in esac # These are the libraries checked by Readline. -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) +AC_SEARCH_LIBS(tgetent, [termcap tinfo tinfow curses ncursesw ncurses]) if test "$ac_cv_search_tgetent" = no; then