diff mbox

Fix inaccuracies in "info skip" help

Message ID 20181110174857.29134-1-simon.marchi@polymtl.ca
State New, archived
Headers

Commit Message

Simon Marchi Nov. 10, 2018, 5:48 p.m. UTC 
  "help info skip" uses "skip info" in its examples, which is not the same
(it ends up creating new skips).  Also, the Type column that is referred
to doesn't exist today.

gdb/ChangeLog:

	* skip.c (_initialize_step_skip): Fix "info skip" help.
---
 gdb/skip.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Tom Tromey Nov. 19, 2018, 10:01 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> "help info skip" uses "skip info" in its examples, which is not the same
Simon> (it ends up creating new skips).  Also, the Type column that is referred
Simon> to doesn't exist today.

Simon> gdb/ChangeLog:

Simon> 	* skip.c (_initialize_step_skip): Fix "info skip" help.

I didn't see this go in, but it looks good to me.

Tom
Simon Marchi Nov. 19, 2018, 10:28 p.m. UTC | #2 
On 2018-11-19 17:01, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> "help info skip" uses "skip info" in its examples, which is not 
> the same
> Simon> (it ends up creating new skips).  Also, the Type column that is 
> referred
> Simon> to doesn't exist today.
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	* skip.c (_initialize_step_skip): Fix "info skip" help.
> 
> I didn't see this go in, but it looks good to me.
> 
> Tom

I had forgotten about it, thanks.  It is now pushed.

Simon
diff mbox

Patch

diff --git a/gdb/skip.c b/gdb/skip.c
index 13db0f6b43c6..a26ec087473e 100644
--- a/gdb/skip.c
+++ b/gdb/skip.c
@@ -698,13 +698,10 @@  Usage: skip delete [NUMBER | RANGES]..."),
            &skiplist);
 
   add_info ("skip", info_skip_command, _("\
-Display the status of skips.  You can specify numbers (e.g. \"skip info 1 3\"), \
-ranges (e.g. \"skip info 4-8\"), or both (e.g. \"skip info 1 3 4-8\").\n\n\
+Display the status of skips.  You can specify numbers (e.g. \"info skip 1 3\"), \
+ranges (e.g. \"info skip 4-8\"), or both (e.g. \"info skip 1 3 4-8\").\n\n\
 If you don't specify any numbers or ranges, we'll show all skips.\n\n\
-Usage: skip info [NUMBER | RANGES]...\n\
-The \"Type\" column indicates one of:\n\
-\tfile        - ignored file\n\
-\tfunction    - ignored function"));
+Usage: info skip [NUMBER | RANGES]..."));
 
   add_setshow_boolean_cmd ("skip", class_maintenance,
 			   &debug_skip, _("\