Patchwork libanl: properly cleanup if first helper thread creation failed (bug 22927)

login
register
mail settings
Submitter Andreas Schwab
Date Nov. 5, 2018, 1:08 p.m.
Message ID <mvm8t27llil.fsf@suse.de>
Download mbox | patch
Permalink /patch/30027/
State New
Headers show

Comments

Andreas Schwab - Nov. 5, 2018, 1:08 p.m.
[BZ #22927]
	* resolv/gai_misc.c (__gai_enqueue_request): Don't crash if
	creating the first helper thread failed.
---
 resolv/gai_misc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Florian Weimer - Nov. 5, 2018, 1:26 p.m.
* Andreas Schwab:

> 	[BZ #22927]
> 	* resolv/gai_misc.c (__gai_enqueue_request): Don't crash if
> 	creating the first helper thread failed.

Looks okay to me.  Thanks.

Florian

Patch

diff --git a/resolv/gai_misc.c b/resolv/gai_misc.c
index e7c3b63cc5..80a2cff835 100644
--- a/resolv/gai_misc.c
+++ b/resolv/gai_misc.c
@@ -261,8 +261,11 @@  __gai_enqueue_request (struct gaicb *gaicbp)
 	      /* We cannot create a thread in the moment and there is
 		 also no thread running.  This is a problem.  `errno' is
 		 set to EAGAIN if this is only a temporary problem.  */
-	      assert (lastp->next == newp);
-	      lastp->next = NULL;
+	      assert (requests == newp || lastp->next == newp);
+	      if (lastp != NULL)
+		lastp->next = NULL;
+	      else
+		requests = NULL;
 	      requests_tail = lastp;
 
 	      newp->next = freelist;