Message ID | 20181024111355.GA13788@delia |
---|---|
State | New, archived |
Headers |
Received: (qmail 109740 invoked by alias); 24 Oct 2018 11:13:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109723 invoked by uid 89); 24 Oct 2018 11:13:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 11:13:50 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3316FABE7 for <gdb-patches@sourceware.org>; Wed, 24 Oct 2018 11:13:48 +0000 (UTC) Date: Wed, 24 Oct 2018 13:13:57 +0200 From: Tom de Vries <tdevries@suse.de> To: gdb-patches@sourceware.org Subject: [OB PATCH][gdb/testsuite] Handle removed valgrind option --db-attach Message-ID: <20181024111355.GA13788@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes |
Commit Message
Tom de Vries
Oct. 24, 2018, 11:13 a.m. UTC
Hi, When running valgrind-db-attach.exp with valgrind version 3.13.0, we get: ... PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind valgrind: Unknown option: --db-attach=yes valgrind: Use --help for more information or consult the user manual. ERROR: Process no longer exists UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started ... The valgrind option --db-attach has been deprecated in version 3.10.0, and removed in version 3.11.0. Fix valgrind-db-attach.exp to replace the ERROR/UNRESOLVED with: ... UNSUPPORTED: gdb.base/valgrind-db-attach.exp: valgrind started ... Tested on x86_64-linux. Committed as obvious. Thanks, - Tom [gdb/testsuite] Handle removed valgrind option --db-attach 2018-10-24 Tom de Vries <tdevries@suse.de> * gdb.base/valgrind-db-attach.exp: Handle removed support for --db-attach in valgrind. --- gdb/testsuite/gdb.base/valgrind-db-attach.exp | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On 10/24/2018 12:13 PM, Tom de Vries wrote: > Hi, > > When running valgrind-db-attach.exp with valgrind version 3.13.0, we get: > ... > PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind > valgrind: Unknown option: --db-attach=yes > valgrind: Use --help for more information or consult the user manual. > ERROR: Process no longer exists > UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started > ... > > The valgrind option --db-attach has been deprecated in version 3.10.0, and > removed in version 3.11.0. > But was it replaced with / renamed to something else equivalent, or the functionality completely eliminated? If the latter, I don't see much value in keeping the test case around going forward. Especially if we have no comment in the source indicating when it stopped being useful... It ends up just being dead weight and future gdb developers won't even realize. Thanks, Pedro Alves > Fix valgrind-db-attach.exp to replace the ERROR/UNRESOLVED with: > ... > UNSUPPORTED: gdb.base/valgrind-db-attach.exp: valgrind started > ... > > Tested on x86_64-linux. > > Committed as obvious. > > Thanks, > - Tom > > [gdb/testsuite] Handle removed valgrind option --db-attach > > 2018-10-24 Tom de Vries <tdevries@suse.de> > > * gdb.base/valgrind-db-attach.exp: Handle removed support for > --db-attach in valgrind. > > --- > gdb/testsuite/gdb.base/valgrind-db-attach.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/valgrind-db-attach.exp b/gdb/testsuite/gdb.base/valgrind-db-attach.exp > index 3be6af5ca9..3e40283a95 100644 > --- a/gdb/testsuite/gdb.base/valgrind-db-attach.exp > +++ b/gdb/testsuite/gdb.base/valgrind-db-attach.exp > @@ -51,6 +51,10 @@ set use_gdb_stub 1 > set test "valgrind started" > # The trailing '.' differs for different memcheck versions. > gdb_test_multiple "" $test { > + -re "valgrind: Unknown option: --db-attach=yes" { > + unsupported $test > + return -1 > + } > -re "Memcheck, a memory error detector\\.?\r\n" { > pass $test > } >
On Wed, 2018-10-24 at 17:29 +0100, Pedro Alves wrote: > On 10/24/2018 12:13 PM, Tom de Vries wrote: > > Hi, > > > > When running valgrind-db-attach.exp with valgrind version 3.13.0, we get: > > ... > > PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind > > valgrind: Unknown option: --db-attach=yes > > valgrind: Use --help for more information or consult the user manual. > > ERROR: Process no longer exists > > UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started > > ... > > > > The valgrind option --db-attach has been deprecated in version 3.10.0, and > > removed in version 3.11.0. > > > > But was it replaced with / renamed to something else equivalent, > or the functionality completely eliminated? --db-attach option functionality was removed, as it was not very reliable and had a bunch of limitations e.g. not supporting threads. Instead, the gdbserver embedded in valgrind allows the user debug a process when valgrind reports an error. I have put on my list of things to do to convert valgrind-attach test to use vgdb (but the conversion is probably not trivial). Philippe
diff --git a/gdb/testsuite/gdb.base/valgrind-db-attach.exp b/gdb/testsuite/gdb.base/valgrind-db-attach.exp index 3be6af5ca9..3e40283a95 100644 --- a/gdb/testsuite/gdb.base/valgrind-db-attach.exp +++ b/gdb/testsuite/gdb.base/valgrind-db-attach.exp @@ -51,6 +51,10 @@ set use_gdb_stub 1 set test "valgrind started" # The trailing '.' differs for different memcheck versions. gdb_test_multiple "" $test { + -re "valgrind: Unknown option: --db-attach=yes" { + unsupported $test + return -1 + } -re "Memcheck, a memory error detector\\.?\r\n" { pass $test }