From patchwork Tue Oct 9 20:00:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29685 Received: (qmail 92865 invoked by alias); 9 Oct 2018 20:01:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 92557 invoked by uid 89); 9 Oct 2018 20:01:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=krebbel X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.187) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 20:01:11 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id E468810F22 for ; Tue, 9 Oct 2018 15:01:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9yBMgnK1Z8YaU9yBZgF4C8; Tue, 09 Oct 2018 15:01:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e5nwEc9QBPb3lf6LzL6c9CEVV13QJeeLp/z3YgD/Vgc=; b=SWneZS0kldAY5lDaRZrMT/WXDZ yb/jB9YkMARDPjAinged9jsTlSSxdVOyH7HN5S2ZhaA5h5H4nXxCPx2z/OBd2jjJZqiq1morT8LAM AgAuN50hTPP6chOXJkb0+bZyY; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:53498 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g9yBM-001y5V-28; Tue, 09 Oct 2018 15:00:40 -0500 From: Tom Tromey To: Andreas Krebbel Cc: tom@tromey.com, gdb-patches@sourceware.org, Andreas Krebbel Subject: Re: [Committed] Python doc build fixes References: <20180915184530.3657-3-tom@tromey.com> <1538985549-19863-1-git-send-email-krebbel@linux.ibm.com> Date: Tue, 09 Oct 2018 14:00:38 -0600 In-Reply-To: <1538985549-19863-1-git-send-email-krebbel@linux.ibm.com> (Andreas Krebbel's message of "Mon, 8 Oct 2018 09:59:09 +0200") Message-ID: <87y3b6c2l5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 >>>>> "Andreas" == Andreas Krebbel writes: Andreas> From: Andreas Krebbel Andreas> I've just committed this patch to fix doc build for me. Thank you. And, sorry about the breakage. Andreas> 2018-10-08 Andreas Krebbel Andreas> * python.texi (Inferior.Architecture): Add "@end defun". Rename Andreas> ref target to "Unwinding Frames in Python". I think you didn't commit the ChangeLog change. Andreas> -particular frame (@pxref{Frames in Python}). Andreas> +particular frame (@pxref{Unwinding Frames in Python}). This was intended to link to the general information about gdb.Frame, not to the node about how to write an unwinder, which seems less relevant in context. However, I typo'd the "in" -- it should have been "In". I'm checking in the appended to change this to what was originally intended. Tom commit 163cffefafb1d427ab46603d98bbfc45e813c9a0 Author: Tom Tromey Date: Tue Oct 9 13:57:10 2018 -0600 Make @pxref for Inferior.architecture point to gdb.Frame documentation This fixes he @pxref in Inferior.architecture to point to the "Frames In Python" node, as originally intended; somewhat reverting an earlier build fix. The initial patch had typod the "In". Tested by "make info". gdb/doc/ChangeLog 2018-10-09 Tom Tromey * python.texi (Inferiors In Python): Link to "Frames In Python", not "Unwinding Frames in Python". diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index c67798399f..0cab170456 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2018-10-09 Tom Tromey + + * python.texi (Inferiors In Python): Link to "Frames In Python", + not "Unwinding Frames in Python". + 2018-10-09 Tom Tromey * gdb.texinfo (Configure Options): Update --enable-ubsan diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index 2320be63dd..ff5fecea1b 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -2865,7 +2865,7 @@ Return the @code{gdb.Architecture} (@pxref{Architectures In Python}) for this inferior. This represents the architecture of the inferior as a whole. Some platforms can have multiple architectures in a single address space, so this may not match the architecture of a -particular frame (@pxref{Unwinding Frames in Python}). +particular frame (@pxref{Frames In Python}). @end defun @findex Inferior.read_memory