Patchwork [gdb/python] Fix cpychecker error in pspy_solib_name

login
register
mail settings
Submitter Tom de Vries
Date Oct. 4, 2018, 6:08 p.m.
Message ID <20181004180825.GA24019@delia>
Download mbox | patch
Permalink /patch/29651/
State New
Headers show

Comments

Tom de Vries - Oct. 4, 2018, 6:08 p.m.
Hi,

When using cpychecker, we run into:
...
gdb/python/py-progspace.c: \
  In function ‘PyObject* pspy_solib_name(PyObject*, PyObject*)’:
gdb/python/py-progspace.c:370:25: error: Mismatching type in call to \
  PyArg_ParseTuple with format code "K" [-Werror]
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc))
  argument 3 ("&pc") had type
    "gdb_py_longest *" (pointing to 64 bits)
  but was expecting
    "long long unsigned int *" (pointing to 64 bits)
  for format code "K"
...

Fix this fixing the type of the variable.

Build and reg-tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/python] Fix cpychecker error in pspy_solib_name

2018-10-04  Tom de Vries  <tdevries@suse.de>

	* python/py-progspace.c (pspy_solib_name): Fix type mismatch in
	PyArg_ParseTuple call.

---
 gdb/python/py-progspace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tom Tromey - Oct. 4, 2018, 10:13 p.m.
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> [gdb/python] Fix cpychecker error in pspy_solib_name

Tom> 2018-10-04  Tom de Vries  <tdevries@suse.de>

Tom> 	* python/py-progspace.c (pspy_solib_name): Fix type mismatch in
Tom> 	PyArg_ParseTuple call.

This is ok.  Thanks for doing this.

Tom

Patch

diff --git a/gdb/python/py-progspace.c b/gdb/python/py-progspace.c
index 1e16b845e0..6395d5bb15 100644
--- a/gdb/python/py-progspace.c
+++ b/gdb/python/py-progspace.c
@@ -362,7 +362,7 @@  static PyObject *
 pspy_solib_name (PyObject *o, PyObject *args)
 {
   char *soname;
-  gdb_py_longest pc;
+  gdb_py_ulongest pc;
   pspace_object *self = (pspace_object *) o;
 
   PSPY_REQUIRE_VALID (self);