From patchwork Thu Oct 4 17:06:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29648 Received: (qmail 118500 invoked by alias); 4 Oct 2018 17:06:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118486 invoked by uid 89); 4 Oct 2018 17:06:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=complaint, Hx-languages-length:1918, gdb_exit, pagination X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Oct 2018 17:06:17 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id F3A2D400F4269 for ; Thu, 4 Oct 2018 12:06:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 874pgEEG1SjJA874pgmG72; Thu, 04 Oct 2018 12:06:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1jJDJDm0V0PRSZ2yXdJ5LUUYi4cfBDqZXPkLfpve0hk=; b=tmcRZ0+3ETUpRrfcwgvbLAexTR zIBMLnoUWpkouGml2dprQXYhzA0gz0COqfAxoRfcsLFiGhpvSORXgtMCfMP8V7fRWt3/rOWjYYCH6 PSHVkdorbiMfMm4yiMqAwDrvh; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:37926 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g874p-0009S5-NE; Thu, 04 Oct 2018 12:06:15 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] Avoid pagination in attach.exp Date: Thu, 4 Oct 2018 11:06:11 -0600 Message-Id: <20181004170611.28518-1-tom@tromey.com> While re-testing the complaint series, I saw some unresolved tests in attach.exp. In particular, the tests were failing because the pager was active. This is partly a new problem, introduced because that series changes some prints from unfiltered to filtered. However, it is also a latent bug, which you can see by shrinking your window very small and then running the test. This patch avoids the problem by passing -quiet to gdb and arranging to set the window height and width in one other test. Arguably instead of -quiet we should disable the pager during gdb's welcome message. I can do that if it seems desirable; but meanwhile this patch is safe. gdb/testsuite/ChangeLog 2018-10-04 Tom Tromey * gdb.base/attach.exp (test_command_line_attach_run): Use -quiet; set width and height to 0. (test_command_line_attach_run): Use -quiet. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/attach.exp | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/attach.exp b/gdb/testsuite/gdb.base/attach.exp index 8199a80c6b..3f3a0edbb9 100644 --- a/gdb/testsuite/gdb.base/attach.exp +++ b/gdb/testsuite/gdb.base/attach.exp @@ -376,7 +376,8 @@ proc do_command_attach_tests {} { gdb_exit - set res [gdb_spawn_with_cmdline_opts "--pid=$testpid"] + set res [gdb_spawn_with_cmdline_opts \ + "-quiet -iex \"set height 0\" -iex \"set width 0\" --pid=$testpid"] set test "starting with --pid" gdb_test_multiple "" $test { -re "Reading symbols from.*$gdb_prompt $" { @@ -408,7 +409,7 @@ proc test_command_line_attach_run {} { gdb_exit set res [gdb_spawn_with_cmdline_opts \ - "-iex \"set height 0\" -iex \"set width 0\" --pid=$testpid -ex \"start\""] + "-quiet -iex \"set height 0\" -iex \"set width 0\" --pid=$testpid -ex \"start\""] if { $res != 0} { fail $test kill_wait_spawned_process $test_spawn_id