Patchwork [pushed] Remove struct keyword in range-based for

login
register
mail settings
Submitter Simon Marchi
Date Oct. 3, 2018, 9:53 p.m.
Message ID <20181003215310.16614-1-simon.marchi@polymtl.ca>
Download mbox | patch
Permalink /patch/29640/
State New
Headers show

Comments

Simon Marchi - Oct. 3, 2018, 9:53 p.m.
I get the following error with gcc 6.3.0:

/home/simark/src/binutils-gdb/gdb/dwarf2read.c: In function 'void read_func_scope(die_info*, dwarf2_cu*)':
/home/simark/src/binutils-gdb/gdb/dwarf2read.c:13838:12: error: types may not be defined in a for-range-declaration [-Werror]
       for (struct symbol *sym : template_args)
            ^~~~~~

Removing the struct keyword fixes it.

gdb/ChangeLog:

	* dwarf2read.c (read_func_scope): Remove struct keyword in
	range-based for.
---
 gdb/ChangeLog    | 5 +++++
 gdb/dwarf2read.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 57b85dce76d5..77531109a42e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-10-03  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* dwarf2read.c (read_func_scope): Remove struct keyword in
+	range-based for.
+
 2018-10-03  Tom Tromey  <tom@tromey.com>
 
 	* README: Mention --enable-ubsan.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 7004299a9146..929a8be73874 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -13835,7 +13835,7 @@  read_func_scope (struct die_info *die, struct dwarf2_cu *cu)
 	 though they don't appear in this symtab directly, other parts
 	 of gdb assume that symbols do, and this is reasonably
 	 true.  */
-      for (struct symbol *sym : template_args)
+      for (symbol *sym : template_args)
 	symbol_set_symtab (sym, symbol_symtab (templ_func));
     }