Patchwork [3/3] Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc.

login
register
mail settings
Submitter John Baldwin
Date Oct. 3, 2018, 5:34 p.m.
Message ID <c60ce6b4-8035-af87-e2a2-116b9afa90f9@FreeBSD.org>
Download mbox | patch
Permalink /patch/29632/
State New
Headers show

Comments

John Baldwin - Oct. 3, 2018, 5:34 p.m.
On 10/2/18 6:21 AM, Pedro Alves wrote:
> On 10/01/2018 05:33 PM, John Baldwin wrote:
>> On 10/1/18 3:32 AM, Pedro Alves wrote:
>>> As preparation for multi-target, this patch makes each inferior have
>>> its own thread list.
>>
>> The BSD-related bits all look fine to me.  Do you have an existing branch
>> for this on github that I can pull down to do some simple run-time testing?
> 
> I've pushed it now to users/palves/per-inf-thread-list on sourceware.org.

I needed the following patch as a build fix, but it passed some simple
testing of the native target:
Pedro Alves - Oct. 4, 2018, 7:16 p.m.
On 10/03/2018 06:34 PM, John Baldwin wrote:
> On 10/2/18 6:21 AM, Pedro Alves wrote:
>> On 10/01/2018 05:33 PM, John Baldwin wrote:
>>> On 10/1/18 3:32 AM, Pedro Alves wrote:
>>>> As preparation for multi-target, this patch makes each inferior have
>>>> its own thread list.
>>>
>>> The BSD-related bits all look fine to me.  Do you have an existing branch
>>> for this on github that I can pull down to do some simple run-time testing?
>>
>> I've pushed it now to users/palves/per-inf-thread-list on sourceware.org.
> 
> I needed the following patch as a build fix, but it passed some simple
> testing of the native target:
> 
> diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
> index 078cd30c05..991b87852d 100644
> --- a/gdb/bsd-kvm.c
> +++ b/gdb/bsd-kvm.c
> @@ -25,7 +25,8 @@
>  #include "regcache.h"
>  #include "target.h"
>  #include "value.h"
> -#include "gdbcore.h"           /* for get_exec_file */
> +#include "gdbcore.h"
> +#include "inferior.h"          /* for get_exec_file */
>  #include "gdbthread.h"
>  
Thanks!  I've merged it into the patch, and force-pushed the
update to the branch.

Thanks,
Pedro Alves

Patch

diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
index 078cd30c05..991b87852d 100644
--- a/gdb/bsd-kvm.c
+++ b/gdb/bsd-kvm.c
@@ -25,7 +25,8 @@ 
 #include "regcache.h"
 #include "target.h"
 #include "value.h"
-#include "gdbcore.h"           /* for get_exec_file */
+#include "gdbcore.h"
+#include "inferior.h"          /* for get_exec_file */
 #include "gdbthread.h"
 
 #include <fcntl.h>