From patchwork Wed Sep 26 17:41:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Darrington X-Patchwork-Id: 29555 Received: (qmail 77007 invoked by alias); 26 Sep 2018 17:42:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 76987 invoked by uid 89); 26 Sep 2018 17:42:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*au, sk:john@da, johndarringtonwattleidau, darrington X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 17:42:01 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w8QHfvKh031785 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Sep 2018 19:41:57 +0200 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id w8QHfvNx031784; Wed, 26 Sep 2018 19:41:57 +0200 Date: Wed, 26 Sep 2018 19:41:57 +0200 From: John Darrington To: Tom Tromey Cc: John Darrington , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Add a dwarf unit type to represent 24 bit values. Message-ID: <20180926174157.mw5eocxlfmgliua7@jocasta.intra> References: <20180829141845.26378-1-john@darrington.wattle.id.au> <20180829141845.26378-3-john@darrington.wattle.id.au> <878t4dvuyf.fsf@tromey.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <878t4dvuyf.fsf@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) After discussion with the gcc folks, it seems that there is an easier and much simpler solution, which I'm attaching. J' On Fri, Sep 07, 2018 at 03:50:00PM -0600, Tom Tromey wrote: >>>>> "John" == John Darrington writes: John> * include/dwarf2.h (enum dwarf_unit_type) [DE_EH_PE_udata3]: New member. John> --- John> include/dwarf2.h | 1 + John> 1 file changed, 1 insertion(+) I'm afraid I didn't look at the earlier discussion of this. dwarf2.h is canonically maintained in the gcc repository. So, any change here has to be sent to gcc-patches and be committed there first. Then the patch can be applied to gdb -- this counts as obvious (IMO). Tom From f2948209c0292d836ade4dda222c1ffe4aa9abe4 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Wed, 19 Sep 2018 10:28:43 +0200 Subject: [PATCH] GDB: Don't abort if the address size is 3 bytes. * gdb/dwarf2-frame.c (encoding_for_size): Deal with the case where size == 3. --- gdb/dwarf2-frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c index 55ab081bff..dfae2aaf97 100644 --- a/gdb/dwarf2-frame.c +++ b/gdb/dwarf2-frame.c @@ -1527,6 +1527,7 @@ encoding_for_size (unsigned int size) { case 2: return DW_EH_PE_udata2; + case 3: case 4: return DW_EH_PE_udata4; case 8: -- 2.11.0