[3/3] Use GNU style for metasyntactic variables in gdbserver

Message ID 20180915025522.18723-4-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey Sept. 15, 2018, 2:55 a.m. UTC
  This changes a couple of places in gdbserver to use the GNU style for
metasyntactic variables.

2018-09-14  Tom Tromey  <tom@tromey.com>

	* remote-utils.c (remote_open): Use GNU style for metasyntactic
	variables.
	* gdbreplay.c (gdbreplay_usage): Use GNU style for metasyntactic
	variables.
---
 gdb/gdbserver/ChangeLog      | 7 +++++++
 gdb/gdbserver/gdbreplay.c    | 2 +-
 gdb/gdbserver/remote-utils.c | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)
  

Comments

Simon Marchi Sept. 16, 2018, 3:17 a.m. UTC | #1
On 2018-09-14 10:55 p.m., Tom Tromey wrote:
> This changes a couple of places in gdbserver to use the GNU style for
> metasyntactic variables.

LGTM.

Simon
  

Patch

diff --git a/gdb/gdbserver/gdbreplay.c b/gdb/gdbserver/gdbreplay.c
index b05209c4d14..9e81541712e 100644
--- a/gdb/gdbserver/gdbreplay.c
+++ b/gdb/gdbserver/gdbreplay.c
@@ -448,7 +448,7 @@  gdbreplay_version (void)
 static void
 gdbreplay_usage (FILE *stream)
 {
-  fprintf (stream, "Usage:\tgdbreplay <logfile> <host:port>\n");
+  fprintf (stream, "Usage:\tgdbreplay LOGFILE HOST:PORT\n");
   if (REPORT_BUGS_TO[0] && stream == stdout)
     fprintf (stream, "Report bugs to \"%s\".\n", REPORT_BUGS_TO);
 }
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 38c90324288..9199a9c7add 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -336,7 +336,7 @@  remote_open (const char *name)
   port_str = strchr (name, ':');
 #ifdef USE_WIN32API
   if (port_str == NULL)
-    error ("Only <host>:<port> is supported on this platform.");
+    error ("Only HOST:PORT is supported on this platform.");
 #endif
 
   if (strcmp (name, STDIO_CONNECTION_NAME) == 0)