diff mbox

[FYI] Use core_addr_to_string_nz in csky_analyze_prologue

Message ID 20180829213430.21317-1-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey Aug. 29, 2018, 9:34 p.m. UTC 
  One of the buildbot builders had a failure on a recent try run:

../../binutils-gdb/gdb/csky-tdep.c: In function CORE_ADDR csky_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, CORE_ADDR, frame_info*, csky_unwind_cache*, lr_type_t):
../../binutils-gdb/gdb/csky-tdep.c:1107:23: error: format %lx expects argument of type long unsigned int, but argument 3 has type CORE_ADDR {aka long long unsigned int} [-Werror=format=]
        "0x%lx\n", addr);
                       ^
../../binutils-gdb/gdb/csky-tdep.c:1419:12: error: format %lx expects argument of type long unsigned int, but argument 3 has type CORE_ADDR {aka long long unsigned int} [-Werror=format=]
        addr);
            ^

The fix is to use core_addr_to_string_nz rather than %lx in
csky-tdep.c.

Tested by rebuilding.  I'm checking this in.

gdb/ChangeLog
2018-08-29  Tom Tromey  <tom@tromey.com>

	* csky-tdep.c (csky_analyze_prologue): Use
	core_addr_to_string_nz.
---
 gdb/ChangeLog   | 5 +++++
 gdb/csky-tdep.c | 8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
index 972ac59affe..95bcead8771 100644
--- a/gdb/csky-tdep.c
+++ b/gdb/csky-tdep.c
@@ -1103,8 +1103,8 @@  csky_analyze_prologue (struct gdbarch *gdbarch,
 					  "csky: found stack adjustment of"
 					  " 0x%x bytes.\n", adjust);
 		      fprintf_unfiltered (gdb_stdlog,
-					  "csky: skipping to new address "
-					  "0x%lx\n", addr);
+					  "csky: skipping to new address %s\n",
+					  core_addr_to_string_nz (addr));
 		      fprintf_unfiltered (gdb_stdlog,
 					  "csky: continuing\n");
 		    }
@@ -1415,8 +1415,8 @@  csky_analyze_prologue (struct gdbarch *gdbarch,
 					  "found stack adjustment of 0x%x"
 					  " bytes.\n", adjust);
 		      fprintf_unfiltered (gdb_stdlog, "csky: "
-					  "skipping to new address 0x%lx\n",
-					  addr);
+					  "skipping to new address %s\n",
+					  core_addr_to_string_nz (addr));
 		      fprintf_unfiltered (gdb_stdlog, "csky: continuing\n");
 		    }
 		  continue;