From patchwork Thu Aug 23 22:57:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 29032 Received: (qmail 125194 invoked by alias); 23 Aug 2018 22:57:25 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 125183 invoked by uid 89); 23 Aug 2018 22:57:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=puzzle X-HELO: mx1.redhat.com From: DJ Delorie To: Joseph Myers Cc: carlos@redhat.com, libc-alpha@sourceware.org, fweimer@redhat.com Subject: Re: V8 test-in-container patch In-Reply-To: (message from Joseph Myers on Thu, 23 Aug 2018 20:43:14 +0000) Date: Thu, 23 Aug 2018 18:57:16 -0400 Message-ID: MIME-Version: 1.0 Joseph Myers writes: > I expect that even if this build gets deferred to when the testsuite is > run, you'll still need to use $(libunwind) Sure, but I'm thinking it also might be a piece of the bootstrap puzzle that we don't (or shouldn't) need to worry about. How's this patch look? The various macros seem undocumented, but this looks like what the various test linkers are using. diff --git a/support/Makefile b/support/Makefile index b5fcb6ed86..166420de70 100644 --- a/support/Makefile +++ b/support/Makefile @@ -165,18 +165,14 @@ ifeq (,$(CXX)) LINKS_DSO_PROGRAM = links-dso-program-c else LINKS_DSO_PROGRAM = links-dso-program -LDLIBS-links-dso-program = -lstdc++ -lgcc_s +LDLIBS-links-dso-program = -lstdc++ $(gnulib-tests) endif (yes, I know it won't apply cleanly, it's part of a bigger mess I'm working with ;)