Patchwork V8 test-in-container patch

login
register
mail settings
Submitter DJ Delorie
Date Aug. 23, 2018, 10:57 p.m.
Message ID <xno9dselo3.fsf@greed.delorie.com>
Download mbox | patch
Permalink /patch/29032/
State New
Headers show

Comments

DJ Delorie - Aug. 23, 2018, 10:57 p.m.
Joseph Myers <joseph@codesourcery.com> writes:
> I expect that even if this build gets deferred to when the testsuite is 
> run, you'll still need to use $(libunwind)

Sure, but I'm thinking it also might be a piece of the bootstrap puzzle
that we don't (or shouldn't) need to worry about.

How's this patch look?  The various macros seem undocumented, but this
looks like what the various test linkers are using.
Joseph Myers - Aug. 23, 2018, 11:30 p.m.
On Thu, 23 Aug 2018, DJ Delorie wrote:

> Joseph Myers <joseph@codesourcery.com> writes:
> > I expect that even if this build gets deferred to when the testsuite is 
> > run, you'll still need to use $(libunwind)
> 
> Sure, but I'm thinking it also might be a piece of the bootstrap puzzle
> that we don't (or shouldn't) need to worry about.
> 
> How's this patch look?  The various macros seem undocumented, but this
> looks like what the various test linkers are using.
> 
> diff --git a/support/Makefile b/support/Makefile
> index b5fcb6ed86..166420de70 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -165,18 +165,14 @@ ifeq (,$(CXX))
>  LINKS_DSO_PROGRAM = links-dso-program-c
>  else
>  LINKS_DSO_PROGRAM = links-dso-program
> -LDLIBS-links-dso-program = -lstdc++ -lgcc_s
> +LDLIBS-links-dso-program = -lstdc++ $(gnulib-tests)

I think the question there is whether the --as-needed in $(gnulib-tests) 
is an issue for this purpose (whether you want the libraries linked in 
even if not used for anything).  Maybe in this case it doesn't matter 
because the libraries in question will in fact always be used.

Patch

diff --git a/support/Makefile b/support/Makefile
index b5fcb6ed86..166420de70 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -165,18 +165,14 @@  ifeq (,$(CXX))
 LINKS_DSO_PROGRAM = links-dso-program-c
 else
 LINKS_DSO_PROGRAM = links-dso-program
-LDLIBS-links-dso-program = -lstdc++ -lgcc_s
+LDLIBS-links-dso-program = -lstdc++ $(gnulib-tests)
 endif
 

(yes, I know it won't apply cleanly, it's part of a bigger mess I'm
working with ;)