diff mbox

[7/7] Remove -Wno-narrowing from warnings.m4

Message ID 20180808232016.12777-8-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey Aug. 8, 2018, 11:20 p.m. UTC 
  This removes -Wno-narrowing from warnings.m4.
This is PR build/23087.

gdb/ChangeLog
2018-08-08  Tom Tromey  <tom@tromey.com>

	PR build/23087:
	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Remove -Wno-narrowing.

gdb/gdbserver/ChangeLog
2018-08-08  Tom Tromey  <tom@tromey.com>

	PR build/23087:
	* configure: Rebuild.
---
 gdb/ChangeLog           | 6 ++++++
 gdb/configure           | 2 +-
 gdb/gdbserver/ChangeLog | 5 +++++
 gdb/gdbserver/configure | 2 +-
 gdb/warning.m4          | 2 +-
 5 files changed, 14 insertions(+), 3 deletions(-)

Comments

Pedro Alves Aug. 9, 2018, 6:10 p.m. UTC | #1 
On 08/09/2018 12:20 AM, Tom Tromey wrote:
> This removes -Wno-narrowing from warnings.m4.
> This is PR build/23087.

OK.  Thanks much for doing this.

Patches 5 and 6 look OK to me too, but you may want to
give the IBM folks some time to comment in case
they'd prefer some other solution.

Thanks,
Pedro Alves
Tom Tromey Aug. 27, 2018, 5:46 p.m. UTC | #2 
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 08/09/2018 12:20 AM, Tom Tromey wrote:
>> This removes -Wno-narrowing from warnings.m4.
>> This is PR build/23087.

Pedro> OK.  Thanks much for doing this.

Pedro> Patches 5 and 6 look OK to me too, but you may want to
Pedro> give the IBM folks some time to comment in case
Pedro> they'd prefer some other solution.

I'm checking this in now.

Tom
diff mbox

Patch

diff --git a/gdb/configure b/gdb/configure
index 9cd0036848..d207c2baf1 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -15412,7 +15412,7 @@  build_warnings="-Wall -Wpointer-arith \
 -Wno-unused -Wunused-value -Wunused-variable -Wunused-function \
 -Wno-switch -Wno-char-subscripts \
 -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
--Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized \
+-Wno-sign-compare -Wno-error=maybe-uninitialized \
 -Wno-mismatched-tags \
 -Wno-error=deprecated-register \
 -Wsuggest-override \
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 043bc216e4..7454cd8ad3 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -7240,7 +7240,7 @@  build_warnings="-Wall -Wpointer-arith \
 -Wno-unused -Wunused-value -Wunused-variable -Wunused-function \
 -Wno-switch -Wno-char-subscripts \
 -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
--Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized \
+-Wno-sign-compare -Wno-error=maybe-uninitialized \
 -Wno-mismatched-tags \
 -Wno-error=deprecated-register \
 -Wsuggest-override \
diff --git a/gdb/warning.m4 b/gdb/warning.m4
index 00e7cd6050..dd338493f9 100644
--- a/gdb/warning.m4
+++ b/gdb/warning.m4
@@ -40,7 +40,7 @@  build_warnings="-Wall -Wpointer-arith \
 -Wno-unused -Wunused-value -Wunused-variable -Wunused-function \
 -Wno-switch -Wno-char-subscripts \
 -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
--Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized \
+-Wno-sign-compare -Wno-error=maybe-uninitialized \
 -Wno-mismatched-tags \
 -Wno-error=deprecated-register \
 -Wsuggest-override \