Patchwork [COMMITTED,aarch64] Fix value of MIN_PAGE_SIZE for testing

login
register
mail settings
Submitter Siddhesh Poyarekar
Date Aug. 8, 2018, 5:18 p.m.
Message ID <20180808171805.19300-1-siddhesh@sourceware.org>
Download mbox | patch
Permalink /patch/28794/
State New
Headers show

Comments

Siddhesh Poyarekar - Aug. 8, 2018, 5:18 p.m.
MIN_PAGE_SIZE is normally set to 4096 but for testing it can be set to
16 so that it exercises the page crossing code for every misaligned
access.  The value was set to 15, which is obviously wrong, so fixed
as obvious and tested.

	* sysdeps/aarch64/strlen.S [TEST_PAGE_CROSS](MIN_PAGE_SIZE):
	Fix value.
---
 ChangeLog                | 5 +++++
 sysdeps/aarch64/strlen.S | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Patch

diff --git a/ChangeLog b/ChangeLog
index d3bb06f596..37fe532a68 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-08-08  Siddhesh Poyarekar  <siddhesh@sourceware.org>
+
+	* sysdeps/aarch64/strlen.S [TEST_PAGE_CROSS](MIN_PAGE_SIZE):
+	Fix value.
+
 2018-08-08  Joseph Myers  <joseph@codesourcery.com>
 
 	* math/libm-test-nextdown.inc (do_test): Move comment to ....
diff --git a/sysdeps/aarch64/strlen.S b/sysdeps/aarch64/strlen.S
index 32292e3b6e..eb773ef532 100644
--- a/sysdeps/aarch64/strlen.S
+++ b/sysdeps/aarch64/strlen.S
@@ -54,7 +54,7 @@ 
 #define REP8_80 0x8080808080808080
 
 #ifdef TEST_PAGE_CROSS
-# define MIN_PAGE_SIZE 15
+# define MIN_PAGE_SIZE 16
 #else
 # define MIN_PAGE_SIZE 4096
 #endif