diff mbox

[FYI] Remove make_cleanup_value_free_to_mark

Message ID 20180719145421.31242-1-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey July 19, 2018, 2:54 p.m. UTC 
  Pedro's patch to introduce gdbscm_wrap removed the last caller of
make_cleanup_value_free_to_mark.  This patch removes this function.

I'm checking this in as obvious.  Tested by rebuilding, and by
grepping.

gdb/ChangeLog
2018-07-19  Tom Tromey  <tom@tromey.com>

	* utils.c (do_value_free_to_mark)
	(make_cleanup_value_free_to_mark): Remove.
	* utils.h (make_cleanup_value_free_to_mark): Remove.
---
 gdb/ChangeLog |  6 ++++++
 gdb/utils.c   | 17 -----------------
 gdb/utils.h   |  4 ----
 3 files changed, 6 insertions(+), 21 deletions(-)
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c28b24053ca..7f254b9ae82 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@ 
+2018-07-19  Tom Tromey  <tom@tromey.com>
+
+	* utils.c (do_value_free_to_mark)
+	(make_cleanup_value_free_to_mark): Remove.
+	* utils.h (make_cleanup_value_free_to_mark): Remove.
+
 2018-07-19  Pedro Alves  <palves@redhat.com>
 
 	* guile/guile-internal.h (gdbscm_wrap): Really make 'args' a
diff --git a/gdb/utils.c b/gdb/utils.c
index 09381d9092d..bfcb45bc950 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -141,23 +141,6 @@  show_pagination_enabled (struct ui_file *file, int from_tty,
    because while they use the "cleanup API" they are not part of the
    "cleanup API".  */
 
-/* Helper for make_cleanup_value_free_to_mark.  */
-
-static void
-do_value_free_to_mark (void *value)
-{
-  value_free_to_mark ((struct value *) value);
-}
-
-/* Free all values allocated since MARK was obtained by value_mark
-   (except for those released) when the cleanup is run.  */
-
-struct cleanup *
-make_cleanup_value_free_to_mark (struct value *mark)
-{
-  return make_cleanup (do_value_free_to_mark, mark);
-}
-
 /* This function is useful for cleanups.
    Do
 
diff --git a/gdb/utils.h b/gdb/utils.h
index c728449429e..68523994b94 100644
--- a/gdb/utils.h
+++ b/gdb/utils.h
@@ -248,10 +248,6 @@  private:
 
 /* Cleanup utilities.  */
 
-/* For make_cleanup_close see common/filestuff.h.  */
-
-extern struct cleanup *make_cleanup_value_free_to_mark (struct value *);
-
 /* A deleter for a hash table.  */
 struct htab_deleter
 {