Patchwork [pushed] gdb: Remove traces of h8300 ecoff support

login
register
mail settings
Submitter Pedro Alves
Date July 11, 2018, 7:48 p.m.
Message ID <506a59f2-48e4-0a2a-dbf9-7d5daa82f5d4@redhat.com>
Download mbox | patch
Permalink /patch/28321/
State New
Headers show

Comments

Pedro Alves - July 11, 2018, 7:48 p.m.
On 04/16/2018 03:07 PM, Pedro Alves wrote:

> I went through this list now, and it looks to me like there's
> not much else we can clean up from gdb.  Support for all of
> these other ports had already been removed from gdb.
> 
> There's just this little bit of ecoff support in the h8300 support
> that I ran into that I think we could remove.  Grepping around BFD,
> I don't think ECOFF is supported for h8300, is it?
> 
> And if not, I'm failing to see why we'd support ECOFF debug info
> in ELF for h8300 (.mdebug).  It kind of seems like someone just installed
> the set_gdbarch_ecoff_reg_to_regnum hook at the same time the dwarf2
> and stabs hooks were installed.
> 
> I'm inclined to remove this so that greps for ecoff stuff
> only lead to MIPS, as ISTR that Linux/MIPS support still
> relies on some subset of ECOFF for something.
I was looking through my local branches and remembered this patch.

I've pushed it in now.  I doubt anyone will miss this.

From a6f88f6e4458e672b8a72ee0c0998fdc79cf601e Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Wed, 11 Jul 2018 20:39:12 +0100
Subject: [PATCH] gdb: Remove traces of h8300 ecoff support

There's this little bit of ecoff support in the h8300 port that I ran
into that I think we could remove.  Grepping around BFD, I don't think
ECOFF is supported for h8300.

And if not, I'm failing to see why we'd support ECOFF debug info in
ELF for h8300 (.mdebug).  It kind of seems like someone just installed
the set_gdbarch_ecoff_reg_to_regnum hook at the same time the dwarf2
and stabs hooks were installed.

I'm removing this so that greps for ecoff stuff only lead to MIPS, as
ISTR that Linux/MIPS support still relies on some subset of ECOFF for
something.

gdb/ChangeLog:
2018-07-11  Pedro Alves  <palves@redhat.com>

	* h8300-tdep.c (h8300_gdbarch_init): Remove
	set_gdbarch_ecoff_reg_to_regnum calls.
---
 gdb/ChangeLog    | 5 +++++
 gdb/h8300-tdep.c | 4 ----
 2 files changed, 5 insertions(+), 4 deletions(-)

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5ac6c604f6a..c82c37ed387 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-07-11  Pedro Alves  <palves@redhat.com>
+
+	* h8300-tdep.c (h8300_gdbarch_init): Remove
+	set_gdbarch_ecoff_reg_to_regnum calls.
+
 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	PR c++/23373
diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c
index 65d33620c6a..5a4802cfe59 100644
--- a/gdb/h8300-tdep.c
+++ b/gdb/h8300-tdep.c
@@ -1265,7 +1265,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300:
       set_gdbarch_num_regs (gdbarch, 13);
       set_gdbarch_num_pseudo_regs (gdbarch, 1);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300_register_name);
@@ -1277,7 +1276,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300hn:
       set_gdbarch_num_regs (gdbarch, 13);
       set_gdbarch_num_pseudo_regs (gdbarch, 1);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300_register_name);
@@ -1297,7 +1295,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300sn:
       set_gdbarch_num_regs (gdbarch, 16);
       set_gdbarch_num_pseudo_regs (gdbarch, 2);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300s_register_name);
@@ -1317,7 +1314,6 @@  h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     case bfd_mach_h8300sxn:
       set_gdbarch_num_regs (gdbarch, 18);
       set_gdbarch_num_pseudo_regs (gdbarch, 2);
-      set_gdbarch_ecoff_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_dwarf2_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_stab_reg_to_regnum (gdbarch, h8300s_dbg_reg_to_regnum);
       set_gdbarch_register_name (gdbarch, h8300sx_register_name);