From patchwork Tue Jul 10 12:28:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 28292 Received: (qmail 5583 invoked by alias); 10 Jul 2018 12:28:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 5570 invoked by uid 89); 10 Jul 2018 12:28:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-vk0-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L5gmqP7xImK3HUf3HBzzwmQw2bh44pzPU6Mn0iOh7qc=; b=TmGcjMpeV1hZo33Q1Nyl3SBzUGr21Xcu+VRp2gz+EwdZN/q7xcRYSNXkGPwEqfZc74 3iNl/0WsNyfhMHRUD6kOL+8XCUyPtR8kHLkOHPWwoNRhTSSAN9ZCk1HwxCjhAyPveY0a 6aIL766ma+dWnmrjibtgZz38Tb+5YwOBmignI= Return-Path: Subject: Re: [PATCH v4] Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251) To: libc-alpha@sourceware.org References: <1529530993-20897-1-git-send-email-adhemerval.zanella@linaro.org> <2afa654e-f565-5a54-0ffe-f112a5bdcf1d@linux.ibm.com> <4427e441-7dad-f2c6-2c82-9e2bf1b9f478@linux.ibm.com> <651c2498-9184-9fb1-a884-f47a0e76e0ae@linaro.org> <7819d60f-598f-3dc6-0a37-56fd60b23bc5@linux.ibm.com> Cc: Carlos O'Donell From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <3c09e43a-b0e7-2be9-0301-2c8d25c6920e@linaro.org> Date: Tue, 10 Jul 2018 09:28:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: On 10/07/2018 03:31, Stefan Liebler wrote: > On 07/09/2018 08:37 PM, Adhemerval Zanella wrote: >> >> So it seems that kernel between 4.13 through 4.15 have this issue with for >> compat kernels and I do think it is a kernel issue because fcntl64 is the >> expected way to use OFD locks.  GLIBC returns EOVERFLOW because from >> application standpoint, it should use LFS variant instead. >> > Yes, I agree with you. > Shall we document this kernel issue in the release-wiki and/or the testcase itself? > I have added a note on 2.28 release wiki [1] about this potential failure and if Carlos approves I would like to push the patch below. [1] https://sourceware.org/glibc/wiki/Release/2.28 Reviewed-by: Carlos O'Donell --- From aca2b996f3ba8fdf76e5e71e3868b701c5aa5c2b Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 10 Jul 2018 09:24:40 -0300 Subject: [PATCH] Comment tst-ofdlocks-compat expected failure in some Linux releases As pointed out in a libc-alpha thread [1], the misc/tst-ofdlocks-compat may fail in some specific Linux releases. This patch adds a comment along with a link to discussion in the test source code. No changes are expected. * sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c: Add a comment about a kernel issue which lead to test failure in some cases. [1] https://sourceware.org/ml/libc-alpha/2018-07/msg00243.html --- ChangeLog | 5 +++++ sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/ChangeLog b/ChangeLog index 7a052c3..9c57396 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-07-10 Adhemerval Zanella + + * sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c: Add a comment about + a kernel issue which lead to test failure in some cases. + 2018-07-06 Florian Weimer [BZ #18991] diff --git a/sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c b/sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c index d1d00eb..03c4abf 100644 --- a/sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c +++ b/sysdeps/unix/sysv/linux/tst-ofdlocks-compat.c @@ -40,6 +40,14 @@ do_prepare (int argc, char **argv) #define PREPARE do_prepare +/* Linux between 4.13 and 4.15 return EOVERFLOW for LFS OFD locks usage + in compat mode (non-LFS ABI running on a LFS default kernel, such as + i386 on a x86_64 kernel or s390-32 on a s390-64 kernel) [1]. This is + a kernel issue because __NR_fcntl64 is the expected way to use OFD locks + (used on GLIBC for both fcntl and fcntl64). + + [1] https://sourceware.org/ml/libc-alpha/2018-07/msg00243.html */ + static int do_test (void) {