Patchwork [1/2] gdb/riscv: Use TYPE_SAFE_NAME

login
register
mail settings
Submitter Andrew Burgess
Date July 10, 2018, 11:58 a.m.
Message ID <42ecac1732194293568ab6093c742ca74c1dbdf6.1531223299.git.andrew.burgess@embecosm.com>
Download mbox | patch
Permalink /patch/28290/
State New
Headers show

Comments

Andrew Burgess - July 10, 2018, 11:58 a.m.
In debug printing, use TYPE_SAFE_NAME instead of replicating the
functionality using TYPE_NAME and a null check.

gdb/ChangeLog:

	* riscv-tdep.c (riscv_print_arg_location): Use TYPE_SAFE_NAME.
---
 gdb/ChangeLog    | 4 ++++
 gdb/riscv-tdep.c | 6 +-----
 2 files changed, 5 insertions(+), 5 deletions(-)

Patch

diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index 4c68ef73fc5..e2be993eaf0 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -1939,12 +1939,8 @@  riscv_print_arg_location (ui_file *stream, struct gdbarch *gdbarch,
 			  struct riscv_arg_info *info,
 			  CORE_ADDR sp_refs, CORE_ADDR sp_args)
 {
-  const char* type_name = TYPE_NAME (info->type);
-  if (type_name == nullptr)
-    type_name = "???";
-
   fprintf_unfiltered (stream, "type: '%s', length: 0x%x, alignment: 0x%x",
-		      type_name, info->length, info->align);
+		      TYPE_SAFE_NAME (info->type), info->length, info->align);
   switch (info->argloc[0].loc_type)
     {
     case riscv_arg_info::location::in_reg: