From patchwork Sat Jul 7 15:17:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 28275 Received: (qmail 40822 invoked by alias); 7 Jul 2018 15:17:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40014 invoked by uid 89); 7 Jul 2018 15:17:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 15:17:44 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B2F6D1E48F; Sat, 7 Jul 2018 11:17:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530976663; bh=z1kc6UfrItgZjFD6oy74qcr6SUadeUCnF9XGSqjbBUI=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=Xs3l1PcfrPZgQud/bE8Hi51pxEoOdNXlIu5yX7QfHYw9kyIP/Ks3dskIs2MCO2w7d EYe9/jID5ME4peMfOla4ulNLImKqLbTEXskFGGbkQqTQr/3to8JlsDxpFYfQe63haI Zqu/5c/KrEXWx2ZF2DdHYFL04HvPQeveytBAw/6g= Subject: Re: [PATCH] Make target_read_alloc & al return vectors From: Simon Marchi To: Andreas Schwab , Simon Marchi Cc: gdb-patches@sourceware.org References: <1521691401-21512-1-git-send-email-simon.marchi@ericsson.com> <5ead66c6-e0cb-c9b6-b882-79c232cc389c@simark.ca> Message-ID: <385ac6f2-e88a-0c40-25a2-d915cc86229c@simark.ca> Date: Sat, 7 Jul 2018 11:17:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <5ead66c6-e0cb-c9b6-b882-79c232cc389c@simark.ca> On 2018-07-07 11:10 AM, Simon Marchi wrote: > In file included from /home/simark/src/binutils-gdb/gdb/ia64-libunwind-tdep.c:39: > /home/simark/src/binutils-gdb/gdb/ia64-libunwind-tdep.c:114:1: error: ISO C++ forbids converting a string constant to ‘char*’ [-Werror=write-strings] > static char *get_reg_name = STRINGIFY(UNW_OBJ(get_reg)); > ^~~~~~~~~~~~~~ > /home/simark/src/binutils-gdb/gdb/common/preprocessor.h:28:25: note: in definition of macro ‘STRINGIFY_1’ > #define STRINGIFY_1(x) #x > ^ Actually, it was quite obvious, so I just pushed this patch. Simon From e83f4d97504515f8c5f290eeb25eac87cca6892f Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sat, 7 Jul 2018 11:13:14 -0400 Subject: [PATCH] ia64-tdep.c: Fix -Wwrite-strings errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Simply add const where necessary to get rid of errors like: /home/simark/src/binutils-gdb/gdb/ia64-libunwind-tdep.c:114:1: error: ISO C++ forbids converting a string constant to ‘char*’ [-Werror=write-strings] static char *get_reg_name = STRINGIFY(UNW_OBJ(get_reg)); ^~~~~~~~~~~~~~ /home/simark/src/binutils-gdb/gdb/common/preprocessor.h:28:25: note: in definition of macro ‘STRINGIFY_1’ #define STRINGIFY_1(x) #x ^ /home/simark/src/binutils-gdb/gdb/ia64-libunwind-tdep.c:114:29: note: in expansion of macro ‘STRINGIFY’ static char *get_reg_name = STRINGIFY(UNW_OBJ(get_reg)); ^~~~~~~~~ gdb/ChangeLog: * ia64-tdep.c (get_reg_name, get_fpreg_name, get_saveloc_name, is_signal_frame_name, step_name, init_remote_name, create_addr_space_name, destroy_addr_space_name, search_unwind_table_name, find_dyn_list_name): Constify. --- gdb/ChangeLog | 7 +++++++ gdb/ia64-libunwind-tdep.c | 22 ++++++++++++---------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 17146e810a37..076f571e2a8b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2018-07-07 Simon Marchi + + * ia64-tdep.c (get_reg_name, get_fpreg_name, get_saveloc_name, + is_signal_frame_name, step_name, init_remote_name, + create_addr_space_name, destroy_addr_space_name, + search_unwind_table_name, find_dyn_list_name): Constify. + 2018-07-05 Simon Marchi * darwin-nat.c (darwin_pthread_kill): New function. diff --git a/gdb/ia64-libunwind-tdep.c b/gdb/ia64-libunwind-tdep.c index 99782b2d7016..b7eef4ac644a 100644 --- a/gdb/ia64-libunwind-tdep.c +++ b/gdb/ia64-libunwind-tdep.c @@ -111,17 +111,19 @@ struct libunwind_frame_cache #define LIBUNWIND_SO_7 "libunwind-" STRINGIFY(UNW_TARGET) ".so.7" #endif -static char *get_reg_name = STRINGIFY(UNW_OBJ(get_reg)); -static char *get_fpreg_name = STRINGIFY(UNW_OBJ(get_fpreg)); -static char *get_saveloc_name = STRINGIFY(UNW_OBJ(get_save_loc)); -static char *is_signal_frame_name = STRINGIFY(UNW_OBJ(is_signal_frame)); -static char *step_name = STRINGIFY(UNW_OBJ(step)); -static char *init_remote_name = STRINGIFY(UNW_OBJ(init_remote)); -static char *create_addr_space_name = STRINGIFY(UNW_OBJ(create_addr_space)); -static char *destroy_addr_space_name = STRINGIFY(UNW_OBJ(destroy_addr_space)); -static char *search_unwind_table_name +static const char *get_reg_name = STRINGIFY(UNW_OBJ(get_reg)); +static const char *get_fpreg_name = STRINGIFY(UNW_OBJ(get_fpreg)); +static const char *get_saveloc_name = STRINGIFY(UNW_OBJ(get_save_loc)); +static const char *is_signal_frame_name = STRINGIFY(UNW_OBJ(is_signal_frame)); +static const char *step_name = STRINGIFY(UNW_OBJ(step)); +static const char *init_remote_name = STRINGIFY(UNW_OBJ(init_remote)); +static const char *create_addr_space_name + = STRINGIFY(UNW_OBJ(create_addr_space)); +static const char *destroy_addr_space_name + = STRINGIFY(UNW_OBJ(destroy_addr_space)); +static const char *search_unwind_table_name = STRINGIFY(UNW_OBJ(search_unwind_table)); -static char *find_dyn_list_name = STRINGIFY(UNW_OBJ(find_dyn_list)); +static const char *find_dyn_list_name = STRINGIFY(UNW_OBJ(find_dyn_list)); static struct libunwind_descr * libunwind_descr (struct gdbarch *gdbarch)