| Message ID | 20180704142954.4F54743994575@oldenburg.str.redhat.com |
|---|---|
| State | Committed |
| Headers |
Received: (qmail 76647 invoked by alias); 4 Jul 2018 14:29:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 76156 invoked by uid 89); 4 Jul 2018 14:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=essential, Hx-languages-length:693 X-HELO: mx1.redhat.com Date: Wed, 04 Jul 2018 16:29:54 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20180704142954.4F54743994575@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) |
Commit Message
Florian Weimer
July 4, 2018, 2:29 p.m. UTC
Otherwise, it is impossible to set ASFLAGS differently from CFLAGS without also overriding essential flags such as -Wa,--noexecstack. 2018-07-04 Florian Weimer <fweimer@redhat.com> * Makeconfig (ASFLAGS): Always append required assembler flags.
Comments
On 07/04/2018 04:29 PM, Florian Weimer wrote: > Otherwise, it is impossible to set ASFLAGS differently from CFLAGS > without also overriding essential flags such as -Wa,--noexecstack. > > 2018-07-04 Florian Weimer <fweimer@redhat.com> > > * Makeconfig (ASFLAGS): Always append required assembler flags. > > diff --git a/Makeconfig b/Makeconfig > index 608ffe648c..099f184088 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -1047,7 +1047,7 @@ endif > ifndef ASFLAGS > ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS)) > endif > -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) > +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) > > ifndef BUILD_CC > BUILD_CC = $(CC) Ping? Thanks, Florian
On Tue, 14 Aug 2018, Florian Weimer wrote: >On 07/04/2018 04:29 PM, Florian Weimer wrote: >> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS >> without also overriding essential flags such as -Wa,--noexecstack. I understood that this patch will let us set ASFLAGS from the command-line. You mentioned CFLAGS because that's how we could indirectly set ASFLAGS, right? If so, looks good to me. >> --- a/Makeconfig >> +++ b/Makeconfig >> @@ -1047,7 +1047,7 @@ endif >> ifndef ASFLAGS >> ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS)) >> endif >> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) >> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) >> >> ifndef BUILD_CC >> BUILD_CC = $(CC) > >Ping?
On 08/16/2018 03:00 PM, Gabriel F. T. Gomes wrote: > On Tue, 14 Aug 2018, Florian Weimer wrote: > >> On 07/04/2018 04:29 PM, Florian Weimer wrote: >>> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS >>> without also overriding essential flags such as -Wa,--noexecstack. > > I understood that this patch will let us set ASFLAGS from the > command-line. You mentioned CFLAGS because that's how we could indirectly > set ASFLAGS, right? Correct, but it also affects compilation of C sources, so it is not always desirable to use this. > If so, looks good to me. Thanks for the review! Florian
On 08/14/2018 11:57 AM, Florian Weimer wrote: > On 07/04/2018 04:29 PM, Florian Weimer wrote: >> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS >> without also overriding essential flags such as -Wa,--noexecstack. >> >> 2018-07-04 Florian Weimer <fweimer@redhat.com> >> >> * Makeconfig (ASFLAGS): Always append required assembler flags. >> >> diff --git a/Makeconfig b/Makeconfig >> index 608ffe648c..099f184088 100644 >> --- a/Makeconfig >> +++ b/Makeconfig >> @@ -1047,7 +1047,7 @@ endif >> ifndef ASFLAGS >> ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS)) >> endif >> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) >> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) This looks correct to me. >> ifndef BUILD_CC >> BUILD_CC = $(CC) Reviewed-by: Carlos O'Donell <carlos@redhat.com>
diff --git a/Makeconfig b/Makeconfig index 608ffe648c..099f184088 100644 --- a/Makeconfig +++ b/Makeconfig @@ -1047,7 +1047,7 @@ endif ifndef ASFLAGS ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS)) endif -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) ifndef BUILD_CC BUILD_CC = $(CC)