Patchwork [RFC,v3,11/12] C-SKY: Add build-many-glibcs.py support

login
register
mail settings
Submitter Han Mao
Date June 29, 2018, 7:58 a.m.
Message ID <bf18cc1b0ff1b3b98ff4750115d081792ab5cf87.1530246557.git.han_mao@c-sky.com>
Download mbox | patch
Permalink /patch/28126/
State New
Headers show

Comments

Han Mao - June 29, 2018, 7:58 a.m.
* scripts/build-many-glibcs.py: Add C-SKY targets
---
 scripts/build-many-glibcs.py | 7 +++++++
 1 file changed, 7 insertions(+)
Joseph Myers - June 29, 2018, 4:44 p.m.
On Fri, 29 Jun 2018, Mao Han wrote:

> 	* scripts/build-many-glibcs.py: Add C-SKY targets
> ---
>  scripts/build-many-glibcs.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index 601718d..3d658b2a 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -191,6 +191,12 @@ class Context(object):
>                          variant='be8',
>                          gcc_cfg=['--with-float=hard', '--with-arch=armv7-a',
>                                   '--with-fpu=vfpv3'])
> +        self.add_config(arch='csky',
> +                        os_name='linux-gnuabiv2',
> +                        gcc_cfg=['--disable-multilib'])
> +        self.add_config(arch='csky',
> +                        os_name='linux-gnuabiv2',
> +                        gcc_cfg=['--with-float=hard', '--disable-multilib'])

If you have more than one variant with the same arch and os_name, you need 
to have variant='something' to avoid them using the same build directories 
etc.

Also, since you appear to support both big and little endian, you should 
include those variants as well.  Every mutually incompatible ABI variant 
supported by the port should be tested in build-many-glibcs.py (whether 
any non-ABI variants are also tested depends on whether they are different 
enough to be likely to have build issues specific to one such variant).

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index 601718d..3d658b2a 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -191,6 +191,12 @@  class Context(object):
                         variant='be8',
                         gcc_cfg=['--with-float=hard', '--with-arch=armv7-a',
                                  '--with-fpu=vfpv3'])
+        self.add_config(arch='csky',
+                        os_name='linux-gnuabiv2',
+                        gcc_cfg=['--disable-multilib'])
+        self.add_config(arch='csky',
+                        os_name='linux-gnuabiv2',
+                        gcc_cfg=['--with-float=hard', '--disable-multilib'])
         self.add_config(arch='hppa',
                         os_name='linux-gnu')
         self.add_config(arch='i686',
@@ -1247,6 +1253,7 @@  class Config(object):
         arch_map = {'aarch64': 'arm64',
                     'alpha': 'alpha',
                     'arm': 'arm',
+                    'csky': 'csky',
                     'hppa': 'parisc',
                     'i486': 'x86',
                     'i586': 'x86',