Patchwork [RFA,v3,1/6] Remove dead code in end_psymtab

login
register
mail settings
Submitter Tom Tromey
Date June 7, 2018, 4:19 p.m.
Message ID <20180607161955.9800-2-tom@tromey.com>
Download mbox | patch
Permalink /patch/27691/
State New
Headers show

Comments

Tom Tromey - June 7, 2018, 4:19 p.m.
I noticed that there is a bit of dead code in end_psymtab.
This deletes it.

Normally I would investigate a fix for the code.  However, considering
that the code has been this way a long time (since the first import to
sourceware) and considering that dbxread.c is not as important any
more, I think it's safe to just consider that there's no bug.

gdb/ChangeLog
2018-06-07  Tom Tromey  <tromey@redhat.com>

	* dbxread.c (end_psymtab): Remove dead code.
---
 gdb/ChangeLog | 4 ++++
 gdb/dbxread.c | 8 +-------
 2 files changed, 5 insertions(+), 7 deletions(-)

Patch

diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 1b524ec0e22..4092d1cab74 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -2045,13 +2045,7 @@  dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
       ALL_OBJFILE_PSYMTABS (objfile, p1)
       {
 	if (p1->texthigh == 0 && p1->textlow != 0 && p1 != pst)
-	  {
-	    p1->texthigh = pst->textlow;
-	    /* If this file has only data, then make textlow match
-	       texthigh.  */
-	    if (p1->textlow == 0)
-	      p1->textlow = p1->texthigh;
-	  }
+	  p1->texthigh = pst->textlow;
       }
     }