Patchwork Update MAP_TYPE value for hppa from Linux 4.17

login
register
mail settings
Submitter Joseph Myers
Date June 4, 2018, 8:56 p.m.
Message ID <alpine.DEB.2.20.1806042056370.1085@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/27623/
State New
Headers show

Comments

Joseph Myers - June 4, 2018, 8:56 p.m.
This patch updates the hppa definition of MAP_TYPE to reflect a
corresponding change in the Linux kernel in 4.17 (so the value now has
four bits set, as it does on other architectures, although they are
different from other architectures because of hppa differences in
other MAP_* bits).

Tested with build-many-glibcs.py for hppa.

2018-06-04  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/unix/sysv/linux/hppa/bits/mman.h [__USE_MISC]
	(MAP_TYPE): Change value to 0x2b.
Joseph Myers - June 11, 2018, 3:23 p.m.
Ping.  This patch 
<https://sourceware.org/ml/libc-alpha/2018-06/msg00054.html> is pending 
review.
Joseph Myers - June 18, 2018, 10:54 a.m.
Ping^2.  This patch 
<https://sourceware.org/ml/libc-alpha/2018-06/msg00054.html> is still 
pending review.
Adhemerval Zanella Netto - June 18, 2018, 1:07 p.m.
On 18/06/2018 07:54, Joseph Myers wrote:
> Ping^2.  This patch 
> <https://sourceware.org/ml/libc-alpha/2018-06/msg00054.html> is still 
> pending review.
> 

LGTM (it corresponds the commit d5b59a71204b0a9a).
Dave Anglin - June 18, 2018, 1:31 p.m.
On 2018-06-18 6:54 AM, Joseph Myers wrote:
> Ping^2.  This patch
> <https://sourceware.org/ml/libc-alpha/2018-06/msg00054.html> is still
> pending review.
>
The change is correct.  Please install.

Thanks,
Dave

Patch

diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
index 380be7b..250ce38 100644
--- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h
+++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
@@ -36,7 +36,7 @@ 
 #ifdef __USE_MISC
 # define MAP_SHARED_VALIDATE	0x03	/* Share changes and validate
 					   extension flags.  */
-# define MAP_TYPE	0x03		/* Mask for type of mapping */
+# define MAP_TYPE	0x2b		/* Mask for type of mapping */
 #endif
 
 /* Other flags.  */